console commit #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babaq
reviewed
Jun 18, 2025
| @@ -79,10 +80,75 @@ void Awake() | |||
|
|
|||
| void Start() | |||
| { | |||
| exmgr.CollectDefination(cfgmgr.config.ExDir); | |||
| exsmgr.CollectDefination(cfgmgr.config.ExSessionDir); | |||
| if (ui == null) | |||
There was a problem hiding this comment.
no need to check these references, when we drag connect them in editor, it can't be null.
babaq
reviewed
Jun 18, 2025
| UnityEngine.Debug.LogError("找不到 ConfigManager 组件！"); | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
these panel init should be done in ui.cs not here in app manager
babaq
reviewed
Jun 18, 2025
| ui.UpdateExperimentList(exmgr.deffile.Keys.ToList(), cfgmgr.config.FirstTestID); | ||
| ui.UpdateExperimentSessionList(exsmgr.deffile.Keys.ToList()); | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
again, ui related staff should be in ui.cs, not in app manager
babaq
reviewed
Jun 18, 2025
| @@ -201,6 +267,10 @@ public void OnScreenSizeChanged() | |||
| if (exmgr.el.envmgr.MainCamera.Count == 0) { return; } | |||
| var lmc = exmgr.el.envmgr.MainCamera.Where(i => i.ClientID == NetworkManager.ServerClientId).First(); | |||
| lmc?.ReportRpc("ScreenAspect", Base.ScreenAspect); | |||
| if (ui != null) | |||
There was a problem hiding this comment.
when quit, no need to update view
babaq
reviewed
Jun 18, 2025
| @@ -675,5 +752,12 @@ public void LoadCurrentScene() | |||
|
|
|||
| } | |||
|
|
|||
There was a problem hiding this comment.
wantstoquit is to quit the application, on destroy() called when delete app manager object, not the same. shouldn't add this.
babaq
reviewed
Jun 18, 2025
| @@ -75,7 +75,8 @@ public static Dictionary<string, List<object>> ReadConditionFile(string path) | |||
| { | |||
| if (!File.Exists(path)) | |||
| { | |||
| Debug.LogError($"Condition File: {path} Not Found."); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.