Skip to content

Change window color tint handling method #3630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Jun 4, 2025

What's the PR

Problem

  • In actual use, there are occasional issues where DWM doesn't update properly during show/hide situations. Calling SetBlur every time the window becomes active can fix it, but this consumes a lot of resources. The root cause is unknown. If this issue can be resolved, the change could be applied.

@prlabeler prlabeler bot added the bug Something isn't working label Jun 4, 2025

This comment has been minimized.

This comment has been minimized.

@Jack251970 Jack251970 added this to the 1.20.1 milestone Jun 4, 2025
@jjw24 jjw24 modified the milestones: 1.20.1, Future Jun 13, 2025

This comment has been minimized.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 22
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@onesounds
Copy link
Contributor Author

This bug is a bit tricky to fix. In some cases, previous rendering artifacts remain, so we need to flush them when showing the window, but it's not working well. Even if it does work, if the transparency is too high, it's hard to design the UI to look like a proper application (text color becomes an issue). The property helps prevent rendering blinks without transparency, but it doesn't seem necessary at the moment. I'll keep it in mind for now but won't implement it yet.

@onesounds onesounds closed this Jun 19, 2025
@jjw24 jjw24 removed this from the Future milestone Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10 min review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Recent Update Broke Some Acrylic/Blur Themes
3 participants