Skip to content

Skip release note notification for dev builds #3703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

onesounds
Copy link
Contributor

What's the PR

  • Skip release note notification for dev version (1.0.0)
  • When we add the release‐channel switch feature later, we’ll need to adjust this part too. We should suppress the notification if the version number goes down (for example, when moving from the beta channel back to stable).
  • I totally forgot to mention that during the code review.

@prlabeler prlabeler bot added the enhancement New feature or request label Jun 11, 2025
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 24
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

Forbidden patterns 🙅 (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Copy link

gitstream-cm bot commented Jun 11, 2025

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

@Jack251970
Copy link
Member

Jack251970 commented Jun 11, 2025

Let us keep it until 1.20.1 release

@Jack251970 Jack251970 added this to the Future milestone Jun 11, 2025
@Jack251970 Jack251970 merged commit 9367dfc into Flow-Launcher:dev Jun 14, 2025
9 checks passed
@jjw24 jjw24 modified the milestones: Future, 2.0.0 Jun 14, 2025
@jjw24 jjw24 added Dev branch only An issue or fix for the Dev branch build and removed enhancement New feature or request labels Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev branch only An issue or fix for the Dev branch build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants