-
Notifications
You must be signed in to change notification settings - Fork 169
Add ci sanitizers #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add ci sanitizers #234
Conversation
Let's see if that works as intended :) |
@Martinsos You need to approve that I can run CI |
@armintoepfer thanks for the PR! Would you mind updating this PR with the latest Also, just to clarify, since my C/C++ knowledge is quite rusty: this is an additional build that runs sanitizers for address and for udefined behaviours (UB). You also added lundef=true which checks for missing symbols. Is there anything else we should be adding, that is also a good practice to check for, or is this it? Thanks! Looking forward to merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small suggestions.
# Additional arguments for meson setup | ||
MESON_SETUP_ARGS ?= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Additional arguments for meson setup | |
MESON_SETUP_ARGS ?= | |
MESON_SETUP_ADDITIONAL_ARGS ?= |
@@ -21,7 +23,8 @@ configure: | |||
rm -rf ${BUILD_DIR} | |||
meson setup ${BUILD_DIR} . \ | |||
--backend=ninja \ | |||
-Ddefault_library=${LIBRARY_TYPE} | |||
-Ddefault_library=${LIBRARY_TYPE} \ | |||
${MESON_SETUP_ARGS} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
${MESON_SETUP_ARGS} | |
${MESON_SETUP_ADDITIONAL_ARGS} |
@@ -66,6 +66,7 @@ jobs: | |||
run: | | |||
make CXXFLAGS="-Werror" LIBRARY_TYPE=static BUILD_DIR=meson-build-static | |||
make CXXFLAGS="-Werror" LIBRARY_TYPE=shared BUILD_DIR=meson-build-shared | |||
make CXXFLAGS="-Werror" LIBRARY_TYPE=static MESON_SETUP_ARGS="--buildtype debugoptimized -Db_sanitize=address,undefined -Db_lundef=true" BUILD_DIR=meson-build-static-debopt-ubasan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make CXXFLAGS="-Werror" LIBRARY_TYPE=static MESON_SETUP_ARGS="--buildtype debugoptimized -Db_sanitize=address,undefined -Db_lundef=true" BUILD_DIR=meson-build-static-debopt-ubasan | |
make CXXFLAGS="-Werror" LIBRARY_TYPE=static MESON_SETUP_ADDITIONAL_ARGS="--buildtype debugoptimized -Db_sanitize=address,undefined -Db_lundef=true" BUILD_DIR=meson-build-static-debug |
No description provided.