Migrate from Legacy OSSRH to Central Portal #2233
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ihrasko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the project's Maven build configuration to transition from the legacy OSSRH platform to the new Central Portal for publishing artifacts. This migration streamlines the release process by incorporating the dedicated Central Publishing Maven Plugin and removing outdated distribution management configurations.
Highlights
- Maven Central Portal Integration: The
central-publishing-maven-plugin(version 0.7.0) has been added to thereleaseprofile inlighty-core/dependency-versions/pom.xml,lighty-core/lighty-bom/pom.xml,lighty-core/lighty-minimal-parent/pom.xml, andlighty-resources/log4j2-config/pom.xml. This plugin is crucial for facilitating artifact publication to the new Central Portal. - Distribution Management Simplification: The explicit
<distributionManagement>sections, which previously defined artifact deployment locations, have been removed from allpom.xmlfiles. This is because the new Central Publishing Plugin now manages artifact deployment, rendering these explicit configurations obsolete.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The changes in this pull request migrate the Maven deployment configuration from the legacy OSSRH to the new Sonatype Central Portal. This involves removing the old distributionManagement sections and adding the central-publishing-maven-plugin to the relevant POM files. The modifications are consistent and follow the recommended guidelines for this migration. No issues requiring changes were found in the diffs.
|
Let's revalidate if not-validated artifacts we being deployed to maven central previously. |
OSSRH is going down. We are going to use Maven plugin to deploy to Central Portal: https://central.sonatype.org/publish/publish-portal-maven/ JIRA: LIGHTY-370 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Use central-publishing-maven-plugin to mvn deploy artifacts during release profile invocation (mvn release:perform). See: https://central.sonatype.org/publish/publish-portal-maven/ JIRA: LIGHTY-370 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Fix relative paths to POM parents as a root cause of Central Portal validation errors for some artifacts (exactly 26). Those artifacts should inherit SCM name and url from its parent when properly configured. JIRA: LIGHTY-374 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Add missing SCM name and url to some artifacts. JIRA: LIGHTY-374 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Exclude skipped 25 artifacts by maven.deploy.skip from publishing to maven central. JIRA: LIGHTY-374 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Follow: What is different between Central Portal and Legacy OSSRH?.