Skip to content

[java] Made JsonToWebElementConverter methods/fields protected #15885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
*/
public class JsonToWebElementConverter implements Function<Object, Object> {

private final RemoteWebDriver driver;
protected final RemoteWebDriver driver;

public JsonToWebElementConverter(RemoteWebDriver driver) {
this.driver = driver;
Expand Down Expand Up @@ -81,15 +81,15 @@ protected RemoteWebElement newRemoteWebElement() {
return setOwner(new RemoteWebElement());
}

private RemoteWebElement setOwner(RemoteWebElement element) {
protected RemoteWebElement setOwner(RemoteWebElement element) {
if (driver != null) {
element.setParent(driver);
element.setFileDetector(driver.getFileDetector());
}
return element;
}

private String getElementKey(Map<?, ?> resultAsMap) {
protected String getElementKey(Map<?, ?> resultAsMap) {
for (Dialect d : Dialect.values()) {
String elementKeyForDialect = d.getEncodedElementKey();
if (resultAsMap.containsKey(elementKeyForDialect)) {
Expand All @@ -99,7 +99,7 @@ private String getElementKey(Map<?, ?> resultAsMap) {
return null;
}

private String getShadowRootKey(Map<?, ?> resultAsMap) {
protected String getShadowRootKey(Map<?, ?> resultAsMap) {
for (Dialect d : Dialect.values()) {
String shadowRootElementKey = d.getShadowRootElementKey();
if (resultAsMap.containsKey(shadowRootElementKey)) {
Expand Down