Skip to content

[py] Deprecate support for FTP proxies #15906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 19, 2025

Conversation

cgoldberg
Copy link
Contributor

@cgoldberg cgoldberg commented Jun 17, 2025

User description

🔗 Related Issues

#15905

💥 What does this PR do?

This PR adds a deprecation warning when trying to set an ftpProxy.

💡 Additional Considerations

Newer browsers already don't support FTP proxies, but we will deprecate it in case users are pinned to older browsers that still support it.

🔄 Types of changes

  • Deprecation

PR Type

Other


Description

• Deprecate FTP proxy support with warning message
• Add TODO comments for future removal
• Update tests with deprecation comments
• Minor formatting improvements to docstrings


Changes walkthrough 📝

Relevant files
Enhancement
proxy.py
Add FTP proxy deprecation warning                                               

py/selenium/webdriver/common/proxy.py

• Add deprecation warning when setting ftpProxy
• Import warnings
module for deprecation handling
• Add TODO comments for future removal

• Minor docstring formatting improvements

+17/-3   
Tests
proxy_tests.py
Update tests with deprecation comments                                     

py/test/selenium/webdriver/common/proxy_tests.py

• Add TODO comments referencing FTP proxy deprecation
• Update test
comments to indicate deprecated status
• Reference GitHub issue for
future removal

+8/-0     

Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    qodo-merge-pro bot commented Jun 17, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @SeleniumHQ SeleniumHQ deleted a comment from qodo-merge-pro bot Jun 17, 2025
    @cgoldberg cgoldberg merged commit 21b10ad into SeleniumHQ:trunk Jun 19, 2025
    26 of 29 checks passed
    @cgoldberg cgoldberg deleted the py-deprecate-ftp-proxy branch June 19, 2025 19:45
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants