[dotnet] [bidi] Protect DTO types from inheritance #15919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
|
Thanks Nick, protecting types is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Classes/records in BiDi namespace are not supposed to be inherited.
💥 What does this PR do?
Adds
sealedmodifier for them.🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Other
Description
• Add
sealedmodifier to BiDi DTO classes and records• Prevent inheritance of BiDi namespace types
• Improve type safety across Browser, BrowsingContext, Input, Log, Network, Script, Session, and Storage modules
Changes walkthrough 📝
72 files
Add sealed modifier to ClientWindow recordAdd sealed modifier to ClientWindowInfo recordAdd sealed modifier to CloseCommand and CloseOptionsAdd sealed modifier to CreateUserContext typesAdd sealed modifier to GetClientWindows typesAdd sealed modifier to GetUserContexts typesAdd sealed modifier to RemoveUserContext typesAdd sealed modifier to UserContext classAdd sealed modifier to UserContextInfo recordAdd sealed modifier to Activate typesAdd sealed modifier to BrowsingContext classAdd sealed modifier to BrowsingContextInfo recordAdd sealed modifier to BrowsingContextInputModule classAdd sealed modifier to BrowsingContextLogModule classAdd sealed modifier to BrowsingContextModule classAdd sealed modifier to BrowsingContextNetworkModule and optionsAdd sealed modifier to BrowsingContextScriptModule classAdd sealed modifier to BrowsingContextStorageModule classAdd sealed modifier to CaptureScreenshot typesAdd sealed modifier to Close typesAdd sealed modifier to Create typesAdd sealed modifier to GetTree typesAdd sealed modifier to HandleUserPrompt typesAdd sealed modifier to HistoryUpdatedEventArgs recordAdd sealed modifier to LocateNodes typesAdd sealed modifier to Locator typesAdd sealed modifier to Navigate typesAdd sealed modifier to Navigation recordAdd sealed modifier to NavigationInfo recordAdd sealed modifier to Print typesAdd sealed modifier to Reload typesAdd sealed modifier to SetViewport typesAdd sealed modifier to TraverseHistory typesAdd sealed modifier to UserPromptClosedEventArgs recordAdd sealed modifier to UserPromptOpenedEventArgs recordAdd sealed modifier to Key record commentAdd sealed modifier to Origin typesAdd sealed modifier to PerformActions typesAdd sealed modifier to ReleaseActions typesAdd sealed modifier to SetFiles typesAdd sealed modifier to SourceActions typesAdd sealed modifier to LogEntry typesAdd sealed modifier to AddIntercept typesAdd sealed modifier to AuthChallenge recordAdd sealed modifier to AuthCredentials recordAdd sealed modifier to BytesValue typesAdd sealed modifier to ContinueRequest typesAdd sealed modifier to ContinueResponse typesAdd sealed modifier to ContinueWithAuth typesAdd sealed modifier to Cookie recordAdd sealed modifier to CookieHeader recordAdd sealed modifier to FailRequest typesAdd sealed modifier to FetchErrorEventArgs recordAdd sealed modifier to FetchTimingInfo recordAdd sealed modifier to Header recordAdd sealed modifier to Initiator recordAdd sealed modifier to Intercept classAdd sealed modifier to NetworkModule high-level typesAdd sealed modifier to ProvideResponse typesAdd sealed modifier to RemoveIntercept typesAdd sealed modifier to Request classAdd sealed modifier to RequestData recordAdd sealed modifier to ResponseCompletedEventArgs recordAdd sealed modifier to ResponseContent recordAdd sealed modifier to SetCacheBehavior typesAdd sealed modifier to SetCookieHeader recordAdd sealed modifier to UrlPattern typesAdd sealed modifier to AddPreloadScript typesAdd sealed modifier to CallFunction typesAdd sealed modifier to Channel recordAdd sealed modifier to ChannelProperties recordAdd sealed modifier to Disown types2 files
Format ResponseData record parametersFormat ResponseStartedEventArgs record parameters34 files