-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[grid] Add config blocked-routes
and specific blocked-delete-session
in Router
#15920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Code Suggestions ✨No code suggestions found for the PR. |
/review |
PR Reviewer Guide 🔍(Review updated until commit 24e5e23)Here are some key observations to aid the review process:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
…on` in Router Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@pujagani thanks Puja for approval. In the last commit, I added a minor fix for AI review point "Path traversal vulnerability". |
/review |
Persistent review updated to latest commit 24e5e23 |
User description
🔗 Related Issues
💥 What does this PR do?
1. Add a config to support #15808 (a flag to block session deletion - both on UI and API via route filter).
--blocked-delete-session true
when starting Router/Hub/Standalone component. (or similar config name in TOML)2. Extend the feature for advanced users are able to define a list of routes to block.
CLI options
TOML configs
In logs, we can monitor the config apply
User who performs method to route path matched will see the response with status 403
From Router logs, we can also monitor how many blocked methods get hit
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Enhancement
Description
• Add configurable route blocking for Grid components
• Implement specific flag to block session deletion
• Support comma-separated list of blocked routes
• Add comprehensive test coverage for new functionality
Changes walkthrough 📝
5 files
Apply blocked routes filter to Hub
Apply blocked routes filter to Standalone
Create BlockedRoute model class
Implement HTTP request filtering logic
Apply blocked routes filter to RouterServer
3 files
Add CLI flags for route blocking
Parse blocked routes configuration
Add test build configuration
2 files
Test blocked routes filter functionality
Test router options configuration parsing