Skip to content

Bump pdf-annotate.js webpack (low priority) #10641

@micpap25

Description

@micpap25
Contributor

Changes should be made to https://github.com/Submitty/pdf-annotate.js
pdf-annotate.js should be updated to use a webpack version 5. That would require updating many packages and removing the istanbul-instrument-loader package since that is abandoned. This change would increase the security of pdf-annotate.js.

Activity

sxryadipta

sxryadipta commented on Jul 6, 2024

@sxryadipta

Could you please elaborate the issue?

github-actions

github-actions commented on Jul 6, 2024

@github-actions

Hi @sxryadipta,

Thank you for your interest in the Submitty open source project!

We encourage you to join our Zulip server to discuss new features requests, bug reports, and technical implementation questions.

We welcome contributions from new developers! Please read our documentation on how to get started with Submitty, specifically our pages on setting up your development environment and making a pull request.

NOTE: We do not use the Github issue 'assign' feature for first time prospective contributors. You do not need to be assigned to an issue to create a pull request that will be reviewed by our team and then merged if it appropriately resolves the issue.

thepiyush-303

thepiyush-303 commented on Jul 6, 2024

@thepiyush-303

Hi @micpap25
This can be done by running the command:

npm install webpack@latest webpack-cli@latest
and Can you specify which loader you want instead of istanbul-instrument-loader .
Is there a specific implementation you had in mind?
Thankyou

github-actions

github-actions commented on Jul 6, 2024

@github-actions

Hi @thepiyush-303,

Thank you for your interest in the Submitty open source project!

We encourage you to join our Zulip server to discuss new features requests, bug reports, and technical implementation questions.

We welcome contributions from new developers! Please read our documentation on how to get started with Submitty, specifically our pages on setting up your development environment and making a pull request.

NOTE: We do not use the Github issue 'assign' feature for first time prospective contributors. You do not need to be assigned to an issue to create a pull request that will be reviewed by our team and then merged if it appropriately resolves the issue.

micpap25

micpap25 commented on Jul 8, 2024

@micpap25
ContributorAuthor

@thepiyush-303 no specific implementations in mind; just something that allows us to bump to webpack 5. Feel free to open a PR and we'll take a look at it.

ARYANSHAH1567

ARYANSHAH1567 commented on Aug 6, 2024

@ARYANSHAH1567

Hi, just wanted to know is this issue still open?

github-actions

github-actions commented on Aug 6, 2024

@github-actions

Hi @ARYANSHAH1567,

Thank you for your interest in the Submitty open source project!

We encourage you to join our Zulip server to discuss new features requests, bug reports, and technical implementation questions.

We welcome contributions from new developers! Please read our documentation on how to get started with Submitty, specifically our pages on setting up your development environment and making a pull request.

NOTE: We do not use the Github issue 'assign' feature for first time prospective contributors. You do not need to be assigned to an issue to create a pull request that will be reviewed by our team and then merged if it appropriately resolves the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @micpap25@sxryadipta@ARYANSHAH1567@thepiyush-303

      Issue actions

        Bump pdf-annotate.js webpack (low priority) · Issue #10641 · Submitty/Submitty