feat(Device): getBiometricsAuthenticationStatus #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pladaria
commented
Jun 18, 2025
| @@ -1058,92 +1063,6 @@ bottomSheet = (payload: SheetUI) => Promise<SheetResponse> | |||
| being opened (for example, user accidental double tap), it will throw an Error | |||
| with code `423` (Locked) | |||
|
|
|||
| There are some specific cases of bottom sheet, and we have some utility methods | |||
There was a problem hiding this comment.
Unrelated doc update (deprecating some methods)
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jdelga
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new biometrics authentication status feature and updates related documentation, exports, and tests.
- Introduces GET_BIOMETRICS_AUTHENTICATION_STATUS message in the native responses.
- Implements getBiometricsAuthenticationStatus in device.ts with corresponding tests.
- Updates README and index re-exports, and marks legacy bottom sheet methods as deprecated.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/post-message.ts | Adds new response type for biometrics authentication. |
| src/device.ts | Introduces getBiometricsAuthenticationStatus function. |
| src/bottom-sheet.ts | Marks legacy bottom sheet methods as deprecated. |
| src/tests/device-test.ts | Provides test coverage for the new biometrics status feature. |
| index.ts | Re-exports the new function and deprecation comments. |
| README.md | Updates documentation with details for getBiometricsAuthenticationStatus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #216
WEB-2265