Skip to content

source: linux: Add documentation of Ethernet boot for J722S #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chintan013
Copy link

Ethernet boot support has been added to J722s SoC, add documentation for the same.


.. code-block:: text

subnet 10.0.0.0 netmask 255.0.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something tells me this infinite scrolling block of device specific config snippets should be templated at this point.

+------------------+--------------------------------------+-----------------------+------------------------+---------------------------+----------------------------+

Build tiboot3.bin using ``j722s_evm_r5_ethboot_defconfig``. Build tispl.bin and u-boot.img using ``j722s_evm_a53_ethboot_defconfig``. For instructions to build the bootloader images please refer to :ref:`Build-U-Boot-label`.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you want to duplicate information of
source/linux/Foundational_Components/U-Boot/UG-General-Info.rst

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Udit, It is not duplicate information but it is pointing to the steps on how to build U-Boot images to boot via Ethernet using config files mentioned for Ethernet boot.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every column other than Supported interfaces seems to be redundant information already provided under UG-General-Info.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for Ethernet boot for J722S is added recently, and this is a documentation for that. I believe that we do not have a documentation for thatin UG-General-info page. In the table, columns represent- config files to be used by J722S (specific to Ethernet boot), VCI string information which would be used to configure DHCP server during boot stage. We can find the same documentation already present for AM62 and AM64.

@@ -26,6 +26,8 @@ binaries files to be sent over TFTP are listed in the table below.
| | ``am64x_evm_a53_defconfig`` | | :file:`tiboot3.bin` | :file:`tispl.bin` | :file:`u-boot.img` |
+------------------+------------------------------+------------------------+------------------------+---------------------------+---------------------------+

For instructions to build the bootloader images please refer to :ref:`Build-U-Boot-label`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line and the table above it, need to be normalized to 3 spaces.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was added by mistake, I have removed it.

+==================+======================================+=======================+========================+===========================+============================+
| J722s EVM | ``j722s_evm_r5_ethboot_defconfig`` | CPSW NUSS Ethernet | VCI: TI K3 Bootp Boot | VCI: J722S U-Boot R5 SPL | VCI: J722S U-Boot A53 SPL |
| | ``j722s_evm_a53_ethboot_defconfig`` | | :file:`tiboot3.bin` | :file:`tispl.bin` | :file:`u-boot.img` |
+------------------+--------------------------------------+-----------------------+------------------------+---------------------------+----------------------------+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This table should align with the directive and the below section. Remove a space.

Comment on lines 127 to 129
If using ISC dhcpd an example host entry would look like this:

.. code-block:: text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section also needs to be normalized.

Ethernet boot support has been added to J722s SoC, add documentation for
the same.

Signed-off-by: Chintan Vankar <c-vankar@ti.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants