-
Notifications
You must be signed in to change notification settings - Fork 62
doc(linux): Sync AM57 SDK doc form forked repo #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
New warnings found with rstcheck:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll continue reviewing this once the encoding and immediate regressions have been resolved.
Where did this fork come from? Why was it even created to begin with? Foundational components were being updated for the AM57 release here, even if the release specific docs weren't being updated.
linux/Foundational_Components/U-Boot/Apps-SPL-Debug-OpenOCD | ||
linux/Foundational_Components/U-Boot/Apps-SPL-Debug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Direct regression from #272
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this , OCD is not documented ever for AM57, and this is toc for AM57
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was documented as part of #272. I asked if this was applicable to legacy platforms since it was replacing the Apps-SPL-Debug
guide. At the time I was told that the guide was applicable.
@jonaswood01 for more information here.
linux/Foundational_Components/Kernel/Kernel_Drivers/Crypto/SA2UL_OMAP | ||
linux/Foundational_Components/Kernel/Kernel_Drivers/Crypto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File no longer exists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds this
new file mode 100644
index 00000000..3eec6f57
--- /dev/null
+++ b/source/linux/Foundational_Components/Kernel/Kernel_Drivers/Crypto.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because it was never removed in that fork. It was removed here. Please discuss why it was removed with the IP owner.
configs/AM57X/AM57X_linux_toc.txt
Outdated
linux/Foundational_Components/Graphics/index | ||
linux/Foundational_Components_Graphics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will fix
linux/Foundational_Components/Kernel/Kernel_Drivers/PWM | ||
linux/Foundational_Components/Kernel/Kernel_Drivers/QSPI | ||
linux/Foundational_Components/Kernel/Kernel_Drivers/SPI | ||
linux/Foundational_Components/Kernel/Kernel_Drivers/Storage/SATA | ||
linux/Foundational_Components/Kernel/Kernel_Drivers/Storage/NAND | ||
linux/Foundational_Components/Kernel/Kernel_Drivers/Storage/MMC-SD | ||
linux/Foundational_Components/Kernel/Kernel_Drivers/UART | ||
linux/Foundational_Components/Kernel/Kernel_Drivers/UBIFS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why regression, I don't think, we support UBIFS on AM57
configs/AM57X/AM57X_linux_toc.txt
Outdated
linux/Foundational_Components/Graphics/Common/Display | ||
linux/Foundational_Components/Graphics/Common/GTK+_Graphics_Framework | ||
linux/Foundational_Components/Graphics/Common/OpenGL_ES | ||
linux/Foundational_Components/Graphics/Common/PVR_Tools | ||
linux/Foundational_Components/Graphics/Common/QT_Graphics_Framework | ||
linux/Foundational_Components/Graphics/Common/Weston | ||
linux/Foundational_Components/Graphics/SGX/Migration_From_Prior_Releases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will fix it
:: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will fix this
@@ -225,6 +225,7 @@ and DSP processors in a multi-processor environment. | |||
<http://software-dl.ti.com/processor-sdk-rtos/esd/docs/latest/ | |||
rtos/index_Foundational_Components.html#ipc>`__ | |||
|
|||
| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will fix this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more details please
@@ -6,6 +6,7 @@ Troubleshooting | |||
:maxdepth: 3 | |||
|
|||
Apps-TroubleShooting | |||
Apps-SPL-Debug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more details please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more details please
d1087eb
to
501d301
Compare
New warnings found with rstcheck:
|
will address all comments . soon |
Way back during SDK 9.x , 3PE did this fork |
v2: fixed rst warning Signed-off-by: Udit Kumar <u-kumar1@ti.com>
501d301
to
8142356
Compare
New warnings found with rstcheck:
|
@uditkumarti almost all of the regressions I pointed out were due to changes that occurred in this repository being directly overwritten by this PR. Unless there were mandatory changes that occurred in the fork that should outweigh what has occurred here I'm counting it as a regression. (And even if those changes are necessary they should follow renames/removals of those files instead of simply adding the old file as is back to the tree.) |
No description provided.