Add show_context_stack(::AbstractContext)
#909
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #909 +/- ##
==========================================
- Coverage 82.92% 82.81% -0.11%
==========================================
Files 36 36
Lines 3964 3969 +5
==========================================
Hits 3287 3287
- Misses 677 682 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 14815463313Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 14815463313Details
💛 - Coveralls |
mhauru
reviewed
May 6, 2025
There was a problem hiding this comment.
Since the docstring has an example, could that be a doctest?
I wonder if this should be a show(::AbstractContext, ::MIME"text/plain") method. Maybe it omits too much, and the -> thing is too non-standard?
Happy to release this with a patch bump or wait for the next release.
|
I think making this the default show method is a bit too dangerous, it's sometimes useful to see e.g. the sampler in SamplingContext or the values in Condition/FixedContext. |
penelopeysm
changed the title
show_stack(::AbstractContext)show_context_stack(::AbstractContext)
Benchmark Report for Commit 00a4b6bComputer InformationBenchmark Results |
|
I kind of thought about it a bit more, and I'm not sure if this belongs in DPPL proper. I feel like it's a useful function to define for docs, and it was useful for debugging, but it just feels a bit too much like a personal-utility thing to put in here. :/ Feel free to reopen and review again if you disagree, @mhauru as it's in a mergeable state (I added doctests) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docstring says it all. Basically this is a method I've been wanting for ages and I finally decided to implement it after realising that
GibbsContextcontains a complete VarInfo inside it and it's impossible to parse the output of@show context. Obviously I could just run this myself every time I needed it, but I thought it might be useful enough to be added to DynamicPPL itself, hence the PR.Not even sure if this warrants a patch bump + release, opinions are welcome.