-
Notifications
You must be signed in to change notification settings - Fork 152
Revert "Remove kubeconfig value from module invocation log (#826)" #899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Remove kubeconfig value from module invocation log (#826)" #899
Conversation
…ollections#826)" This reverts commit 6efabd3.
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 17s |
@jmighion, please add a changelog fragment |
@yurnov done! |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 22s |
can anyone please approve this? |
+1 for approval — we're currently blocked from upgrading past |
@yurnov please approve this revert for next version |
I'm not maintainer of this repo |
+1 for revert, this is blocking anyone using ansible with a kube_config provided at runtime... |
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 21s |
1705ced
into
ansible-collections:main
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #965 🤖 @patchback |
) This reverts commit 6efabd3. SUMMARY Fixes #870 A better solution is necessary to address #782. The current code makes getting manifests practically unusable. We need to revert this commit until a better solution is found. ISSUE TYPE Bugfix Pull Request COMPONENT NAME kubeconfig Reviewed-by: Bianca Henderson <beeankha@gmail.com> (cherry picked from commit 1705ced)
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #966 🤖 @patchback |
) This reverts commit 6efabd3. SUMMARY Fixes #870 A better solution is necessary to address #782. The current code makes getting manifests practically unusable. We need to revert this commit until a better solution is found. ISSUE TYPE Bugfix Pull Request COMPONENT NAME kubeconfig Reviewed-by: Bianca Henderson <beeankha@gmail.com> (cherry picked from commit 1705ced)
) (#965) This is a backport of PR #899 as merged into main (1705ced). This reverts commit 6efabd3. SUMMARY Fixes #870 A better solution is necessary to address #782. The current code makes getting manifests practically unusable. We need to revert this commit until a better solution is found. ISSUE TYPE Bugfix Pull Request COMPONENT NAME kubeconfig Reviewed-by: Bianca Henderson <beeankha@gmail.com>
) (#966) This is a backport of PR #899 as merged into main (1705ced). This reverts commit 6efabd3. SUMMARY Fixes #870 A better solution is necessary to address #782. The current code makes getting manifests practically unusable. We need to revert this commit until a better solution is found. ISSUE TYPE Bugfix Pull Request COMPONENT NAME kubeconfig Reviewed-by: Bianca Henderson <beeankha@gmail.com>
This reverts commit 6efabd3.
SUMMARY
Fixes #870
A better solution is necessary to address #782. The current code makes getting manifests practically unusable. We need to revert this commit until a better solution is found.
ISSUE TYPE
COMPONENT NAME
kubeconfig