Skip to content

Revert "Remove kubeconfig value from module invocation log (#826)" #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025

Conversation

jmighion
Copy link
Contributor

This reverts commit 6efabd3.

SUMMARY

Fixes #870
A better solution is necessary to address #782. The current code makes getting manifests practically unusable. We need to revert this commit until a better solution is found.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

kubeconfig

Copy link

@yurnov
Copy link
Contributor

yurnov commented Apr 11, 2025

@jmighion, please add a changelog fragment

@jmighion
Copy link
Contributor Author

@yurnov done!

Copy link

@shaleenbathla
Copy link

can anyone please approve this?

@pedro-peter
Copy link

+1 for approval — we're currently blocked from upgrading past kubernetes.core 5.0.0 due to this issue.

@shaleenbathla
Copy link

@yurnov please approve this revert for next version

@yurnov
Copy link
Contributor

yurnov commented May 20, 2025

@yurnov please approve this revert for next version

I'm not maintainer of this repo

@shaleenbathla
Copy link

@beeankha ?

@loicortola
Copy link

+1 for revert, this is blocking anyone using ansible with a kube_config provided at runtime...

Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/c0a71a65a20f45429380ffbc9ecd8e5c

✔️ ansible-galaxy-importer SUCCESS in 3m 21s
✔️ build-ansible-collection SUCCESS in 6m 38s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 1705ced into ansible-collections:main Jul 22, 2025
10 checks passed
Copy link

patchback bot commented Jul 22, 2025

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/1705ced1b5e7b2374877d2a5f9d7c400b59ca2b0/pr-899

Backported as #965

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 22, 2025
)

This reverts commit 6efabd3.
SUMMARY

Fixes #870
A better solution is necessary to address #782. The current code makes getting manifests practically unusable. We need to revert this commit until a better solution is found.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

kubeconfig

Reviewed-by: Bianca Henderson <beeankha@gmail.com>
(cherry picked from commit 1705ced)
Copy link

patchback bot commented Jul 22, 2025

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/1705ced1b5e7b2374877d2a5f9d7c400b59ca2b0/pr-899

Backported as #966

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 22, 2025
)

This reverts commit 6efabd3.
SUMMARY

Fixes #870
A better solution is necessary to address #782. The current code makes getting manifests practically unusable. We need to revert this commit until a better solution is found.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

kubeconfig

Reviewed-by: Bianca Henderson <beeankha@gmail.com>
(cherry picked from commit 1705ced)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jul 22, 2025
) (#965)

This is a backport of PR #899 as merged into main (1705ced).
This reverts commit 6efabd3.
SUMMARY

Fixes #870
A better solution is necessary to address #782. The current code makes getting manifests practically unusable. We need to revert this commit until a better solution is found.

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

kubeconfig

Reviewed-by: Bianca Henderson <beeankha@gmail.com>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jul 22, 2025
) (#966)

This is a backport of PR #899 as merged into main (1705ced).
This reverts commit 6efabd3.
SUMMARY

Fixes #870
A better solution is necessary to address #782. The current code makes getting manifests practically unusable. We need to revert this commit until a better solution is found.

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

kubeconfig

Reviewed-by: Bianca Henderson <beeankha@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubernetes.core.k8s_info redacts data when using in-memory kubeconfig
6 participants