envoy: Bump envoy version to 1.34.x #1302
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayboras
force-pushed
the
pr/tammach/envoy-1.34
branch
from
fb22ec9 to
164ca33
Compare
sayboras
force-pushed
the
pr/tammach/envoy-1.34
branch
6 times, most recently
from
b965a47 to
4dc1236
Compare
|
/test |
sayboras
force-pushed
the
pr/tammach/envoy-1.34
branch
from
4dc1236 to
f3bad46
Compare
sayboras
force-pushed
the
pr/tammach/envoy-1.34
branch
from
f3bad46 to
01e1606
Compare
sayboras
changed the title
sayboras
force-pushed
the
pr/tammach/envoy-1.34
branch
5 times, most recently
from
ed1a44a to
be46604
Compare
jrajahalme
approved these changes
May 13, 2025
There was a problem hiding this comment.
Thanks Tam!
I ran make tests locally (on arm64) without any issues.
Maybe add a reference to the envoy toolchain config into patches/0007-liburing-arm-build.patch so that the flags are less likely to diverge? (even smaller nit: the new patch file is created in an earlier commit for no apparent reason).
sayboras
force-pushed
the
pr/tammach/envoy-1.34
branch
from
be46604 to
8edafff
Compare
jrajahalme
reviewed
May 14, 2025
| + "LD": "/usr/bin/lld-17", | ||
| + }, | ||
| + "//conditions:default": {}, | ||
| + }), |
There was a problem hiding this comment.
Just realized that this was just recently removed in main. Any ideas why this would not be needed for Envoy 1.33, but then needed again in 1.34?
There was a problem hiding this comment.
I think it's related to the new feature introduced in upstream, will dig further once I have time.
Added support for io_uring in the default socket interface.
sayboras
force-pushed
the
pr/tammach/envoy-1.34
branch
6 times, most recently
from
0773933 to
606e551
Compare
sayboras
force-pushed
the
pr/tammach/envoy-1.34
branch
from
606e551 to
f66285d
Compare
sayboras
force-pushed
the
pr/tammach/envoy-1.34
branch
from
f66285d to
b70e2e1
Compare
sayboras
force-pushed
the
pr/tammach/envoy-1.34
branch
from
b70e2e1 to
b103f5b
Compare
Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is already upstream in envoyproxy/envoy#38189
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Relates: envoyproxy/envoy#39027 Signed-off-by: Tam Mach <tam.mach@cilium.io>
Without this patch, we will have the below error. This might be related to new feature in envoy 1.34.0. > Added support for io_uring in the default socket interface. ``` ``` Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
force-pushed
the
pr/tammach/envoy-1.34
branch
from
b103f5b to
f65298e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of regular maintenance. Only merge once 1.18 is released, or 1.32 is EOL.
https://github.com/envoyproxy/envoy/releases/tag/v1.34.0