Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix query for is_first_pull_request #1258

Merged
merged 3 commits into from
Mar 31, 2025
Merged

Conversation

suejung-sentry
Copy link
Contributor

@suejung-sentry suejung-sentry commented Mar 28, 2025

We have a graphQL field isFirstPullRequest on the Repository object that does an expensive query count on pulls table. This is used to evaluate things like

  • whether to show a special banner on Coverage Overview Page
  • whether to show a "No data yet" empty state for Test Analytics page

Update to use a less expensive query (nice idea from @michelletran-codecov )

Closes codecov/engineering-team#3514

@suejung-sentry suejung-sentry requested a review from a team as a code owner March 28, 2025 23:04
Copy link
Contributor

✅ Sentry found no issues in your recent changes ✅

@suejung-sentry suejung-sentry force-pushed the sshin/fix/is-first-pull branch from 1e29048 to a33307c Compare March 28, 2025 23:12
@suejung-sentry suejung-sentry force-pushed the sshin/fix/is-first-pull branch from d65e23b to aab3b8b Compare March 28, 2025 23:30
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (c3ff910) to head (c59da64).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1258      +/-   ##
==========================================
- Coverage   96.32%   96.32%   -0.01%     
==========================================
  Files         492      492              
  Lines       16888    16887       -1     
==========================================
- Hits        16268    16267       -1     
  Misses        620      620              
Flag Coverage Δ
unit 96.32% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@suejung-sentry suejung-sentry added this pull request to the merge queue Mar 31, 2025
Merged via the queue into main with commit cfc7f31 Mar 31, 2025
23 of 24 checks passed
@suejung-sentry suejung-sentry deleted the sshin/fix/is-first-pull branch March 31, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix is_first_pull_request
2 participants