Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove commit author link to base owner page #3808

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

calvin-codecov
Copy link
Contributor

@calvin-codecov calvin-codecov commented Mar 13, 2025

Description

Closes codecov/engineering-team#3368

Link to Sample Entry

https://preview-pr-3808.codecov.dev/github/codecov/codecov-api/commits

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Mar 13, 2025

Bundle Report

Changes will decrease total bundle size by 89 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.11MB -42 bytes (-0.0%) ⬇️
gazebo-production-esm 6.19MB -47 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js -47 bytes 12.29kB -0.38%

Files in assets/index.*.js:

  • ./src/pages/RepoPage/CommitsTab/CommitsTable/Title/Title.tsx → Total Size: 1.69kB
view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js -42 bytes 11.39kB -0.37%

Files in assets/index-legacy.*.js:

  • ./src/pages/RepoPage/CommitsTab/CommitsTable/Title/Title.tsx → Total Size: 1.69kB

Copy link

codecov-public-qa bot commented Mar 13, 2025

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
2907 3 2904 0
View the top 3 failed tests by shortest run time
src/pages/MembersPage/MembersActivation/MembersActivation.test.jsx > Members Activation > MemberActivation > user is currently on a trial > plan auto activate is not undefined > does not render auto activate component
Stack Traces | 0.0321s run time
Error: expect(element).not.toBeInTheDocument()

expected document not to contain element, found <div
  class="border-2 border-ds-gray-primary"
>
  Activation
  <hr
    class="mx-4"
  />
  AutoActivate
</div> instead
 ❯ .../MembersPage/MembersActivation/MembersActivation.test.jsx:148:36
src/services/commit/useCommit.test.tsx > useCommit > when useCommit is called > api returns valid response > returns commit info
Stack Traces | 1.08s run time
AssertionError: expected { commit: { …(12) } } to deeply equal { commit: { author: { …(1) }, …(11) } }

Ignored nodes: comments, script, style
<html>
  <head />
  <body>
    <div />
  </body>
</html>

- Expected
+ Received

  Object {
    "commit": Object {
      "author": Object {
        "username": "febg",
      },
      "branchName": null,
      "ciPassed": true,
      "commitid": "f00162848a3cebc0728d915763c2fd9e92132408",
-     "compareWithParent": Object {
-       "__typename": "Comparison",
-       "directChangedFilesCount": 1,
-       "impactedFiles": Object {
-         "__typename": "ImpactedFiles",
-         "results": Array [],
-       },
-       "indirectChangedFilesCount": 1,
-       "patchTotals": null,
-       "state": "pending",
-     },
+     "compareWithParent": undefined,
      "coverageAnalytics": Object {
        "totals": Object {
          "coverage": 38.30846,
        },
      },
      "createdAt": "2020-08-25T16:35:32",
      "message": "paths test",
      "parent": Object {
        "commitid": "d773f5bc170caec7f6e64420b0967e7bac978a8f",
        "coverageAnalytics": Object {
          "totals": Object {
            "coverage": 38.30846,
          },
        },
      },
      "pullId": 10,
      "state": "complete",
      "uploads": Array [
        Object {
          "buildCode": null,
          "ciUrl": "https://travis-ci..../repo-test/jobs/721065746",
          "createdAt": "2020-08-25T16:36:19.55947400:00",
          "downloadUrl": ".../repo-test/download/build?path=.../F84D6D9A7F883055E40E3B380280BC44/f00162848a3cebc0728d915763c2fd9e92132408/30582d33-de37-4272-ad50-c4dc805802fb.txt",
          "errors": Array [],
          "flags": Array [],
          "id": 0,
          "jobCode": null,
          "name": "upload name",
          "provider": "travis",
          "state": "PROCESSED",
          "updatedAt": "2020-08-25T16:36:19.67986800:00",
          "uploadType": "UPLOADED",
        },
        Object {
          "buildCode": null,
          "ciUrl": "https://travis-ci..../repo-test/jobs/721065763",
          "createdAt": "2020-08-25T16:36:25.82034000:00",
          "downloadUrl": ".../repo-test/download/build?path=.../F84D6D9A7F883055E40E3B380280BC44/f00162848a3cebc0728d915763c2fd9e92132408/18b19f8d-5df6-48bd-90eb-50578ed8812f.txt",
          "errors": Array [],
          "flags": Array [],
          "id": 1,
          "jobCode": null,
          "name": "upload name",
          "provider": "travis",
          "state": "PROCESSED",
          "updatedAt": "2020-08-25T16:36:25.85988900:00",
          "uploadType": "UPLOADED",
        },
      ],
    },
  }

 ❯ .../services/commit/useCommit.test.tsx:412:57runWithExpensiveErrorDiagnosticsDisabled node_modules/@.../dom/dist/config.js:47:12checkCallback node_modules/@.../dom/dist/wait-for.js:124:77Timeout.checkRealTimersCallback node_modules/@.../dom/dist/wait-for.js:118:16
src/ui/FileViewer/ToggleHeader/Title/Title.test.tsx > TitleFlags > when selecting a flag > updates the location params
Stack Traces | 1.17s run time
TestingLibraryElementError: Unable to find an element with the text: flag-1. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full sm:w-60"
    >
      <div
        class="relative"
      >
        <div>
          <button
            aria-controls="downshift-0-menu"
            aria-expanded="false"
            aria-label="Filter by flags"
            class="flex justify-between items-center w-full border border-ds-gray-tertiary rounded bg-ds-container text-left px-3 h-8 disabled:text-ds-gray-quaternary disabled:bg-ds-gray-primary disabled:border-ds-gray-tertiary focus:outline-1 whitespace-nowrap"
            data-marketing="fileviwer-filter-by-flags"
            id="downshift-0-toggle-button"
            tabindex="-1"
          >
            <span
              class="flex items-center gap-2"
            >
              <svg
                class="w-6 h-6"
                data-icon=""
                data-testid=""
                fill="currentColor"
                viewBox="0 0 20 20"
                xmlns="http://www.w3.org/2000/svg"
              >
                <path
                  clip-rule="evenodd"
                  d="M3 6a3 3 0 013-3h10a1 1 0 01.8 1.6L14.25 8l2.55 3.4A1 1 0 0116 13H6a1 1 0 00-1 1v3a1 1 0 11-2 0V6z"
                  fill-rule="evenodd"
                />
              </svg>
              All flags
            </span>
            <svg
              class="w-6 h-6"
              data-icon=""
              data-testid=""
              fill="currentColor"
              viewBox="0 0 20 20"
              xmlns="http://www.w3.org/2000/svg"
            >
              <path
                clip-rule="evenodd"
                d="M5.293 7.293a1 1 0 011.414 0L10 10.586l3.293-3.293a1 1 0 111.414 1.414l-4 4a1 1 0 01-1.414 0l-4-4a1 1 0 010-1.414z"
                fill-rule="evenodd"
              />
            </svg>
          </button>
          <div
            class="absolute inset-x-0 z-50"
          >
            <div
              class="hidden"
            >
              <div>
                <label
                  class="mb-2 block font-semibold sr-only"
                  for="text-input6"
                >
                  Search for Flags
                </label>
                <div
                  class="relative"
                >
                  <div
                    class="absolute left-2 flex h-full items-center text-ds-gray-quaternary"
                  >
                    <svg
                      class="w-4 h-4"
                      data-icon="search"
                      data-testid="search"
                      fill="none"
                      stroke="currentColor"
                      viewBox="0 0 24 24"
                      xmlns="http://www.w3.org/2000/svg"
                    >
                      <path
                        d="M21 21l-6-6m2-5a7 7 0 11-14 0 7 7 0 0114 0z"
                        stroke-linecap="round"
                        stroke-linejoin="round"
                        stroke-width="2"
                      />
                    </svg>
                  </div>
                  <input
                    aria-activedescendant=""
                    aria-autocomplete="list"
                    aria-controls="downshift-0-menu"
                    aria-expanded="false"
                    aria-labelledby="downshift-0-label"
                    autocomplete="off"
                    class="block h-8 w-full border-ds-gray-tertiary bg-ds-container px-3 text-sm disabled:border-ds-gray-tertiary disabled:bg-ds-gray-primary disabled:text-ds-gray-quaternary border-t border-r border-l focus:border rounded-tl rounded-tr pl-7"
                    data-marketing="multiselect-search"
                    id="downshift-0-input"
                    placeholder="Search for Flags"
                    role="combobox"
                    type="text"
                    value=""
                  />
                </div>
              </div>
            </div>
          </div>
        </div>
        <ul
          aria-label="Filter by flags"
          aria-labelledby="downshift-0-label"
          class="overflow-hidden rounded-bl rounded-br bg-ds-container border-ds-gray-tertiary absolute w-full z-40 max-h-80 min-w-fit top-16"
          id="downshift-0-menu"
          role="listbox"
        />
      </div>
    </div>
  </div>
  <div
    aria-live="polite"
    aria-relevant="additions text"
    id="a11y-status-message"
    role="status"
    style="border: 0px; height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; width: 1px;"
  />
</body>

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full sm:w-60"
    >
      <div
        class="relative"
      >
        <div>
          <button
            aria-controls="downshift-0-menu"
            aria-expanded="false"
            aria-label="Filter by flags"
            class="flex justify-between items-center w-full border border-ds-gray-tertiary rounded bg-ds-container text-left px-3 h-8 disabled:text-ds-gray-quaternary disabled:bg-ds-gray-primary disabled:border-ds-gray-tertiary focus:outline-1 whitespace-nowrap"
            data-marketing="fileviwer-filter-by-flags"
            id="downshift-0-toggle-button"
            tabindex="-1"
          >
            <span
              class="flex items-center gap-2"
            >
              <svg
                class="w-6 h-6"
                data-icon=""
                data-testid=""
                fill="currentColor"
                viewBox="0 0 20 20"
                xmlns="http://www.w3.org/2000/svg"
              >
                <path
                  clip-rule="evenodd"
                  d="M3 6a3 3 0 013-3h10a1 1 0 01.8 1.6L14.25 8l2.55 3.4A1 1 0 0116 13H6a1 1 0 00-1 1v3a1 1 0 11-2 0V6z"
                  fill-rule="evenodd"
                />
              </svg>
              All flags
            </span>
            <svg
              class="w-6 h-6"
              data-icon=""
              data-testid=""
              fill="currentColor"
              viewBox="0 0 20 20"
              xmlns="http://www.w3.org/2000/svg"
            >
              <path
                clip-rule="evenodd"
                d="M5.293 7.293a1 1 0 011.414 0L10 10.586l3.293-3.293a1 1 0 111.414 1.414l-4 4a1 1 0 01-1.414 0l-4-4a1 1 0 010-1.414z"
                fill-rule="evenodd"
              />
            </svg>
          </button>
          <div
            class="absolute inset-x-0 z-50"
          >
            <div
              class="hidden"
            >
              <div>
                <label
                  class="mb-2 block font-semibold sr-only"
                  for="text-input6"
                >
                  Search for Flags
                </label>
                <div
                  class="relative"
                >
                  <div
                    class="absolute left-2 flex h-full items-center text-ds-gray-quaternary"
                  >
                    <svg
                      class="w-4 h-4"
                      data-icon="search"
                      data-testid="search"
                      fill="none"
                      stroke="currentColor"
                      viewBox="0 0 24 24"
                      xmlns="http://www.w3.org/2000/svg"
                    >
                      <path
                        d="M21 21l-6-6m2-5a7 7 0 11-14 0 7 7 0 0114 0z"
                        stroke-linecap="round"
                        stroke-linejoin="round"
                        stroke-width="2"
                      />
                    </svg>
                  </div>
                  <input
                    aria-activedescendant=""
                    aria-autocomplete="list"
                    aria-controls="downshift-0-menu"
                    aria-expanded="false"
                    aria-labelledby="downshift-0-label"
                    autocomplete="off"
                    class="block h-8 w-full border-ds-gray-tertiary bg-ds-container px-3 text-sm disabled:border-ds-gray-tertiary disabled:bg-ds-gray-primary disabled:text-ds-gray-quaternary border-t border-r border-l focus:border rounded-tl rounded-tr pl-7"
                    data-marketing="multiselect-search"
                    id="downshift-0-input"
                    placeholder="Search for Flags"
                    role="combobox"
                    type="text"
                    value=""
                  />
                </div>
              </div>
            </div>
          </div>
        </div>
        <ul
          aria-label="Filter by flags"
          aria-labelledby="downshift-0-label"
          class="overflow-hidden rounded-bl rounded-br bg-ds-container border-ds-gray-tertiary absolute w-full z-40 max-h-80 min-w-fit top-16"
          id="downshift-0-menu"
          role="listbox"
        />
      </div>
    </div>
  </div>
  <div
    aria-live="polite"
    aria-relevant="additions text"
    id="a11y-status-message"
    role="status"
    style="border: 0px; height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; width: 1px;"
  />
</body>waitForWrapper node_modules/@.../dom/dist/wait-for.js:163:27node_modules/@.../dom/dist/query-helpers.js:86:33
 ❯ .../ToggleHeader/Title/Title.test.tsx:255:34

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Mar 13, 2025

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
4237 4 4233 2
View the top 3 failed test(s) by shortest run time
src/shared/GlobalTopBanners/TrialBanner/TrialBanner.test.tsx > TrialBanner > owner does not belong to org > renders nothing
Stack Traces | 0.0239s run time
AssertionError: expected 1 to be +0 // Object.is equality

Ignored nodes: comments, script, style
<html>
  <head />
  <body>
    <div />
  </body>
</html>

- Expected
+ Received

- 0
+ 1

 ❯ .../GlobalTopBanners/TrialBanner/TrialBanner.test.tsx:249:60runWithExpensiveErrorDiagnosticsDisabled node_modules/@.../dom/dist/config.js:47:12checkCallback node_modules/@.../dom/dist/wait-for.js:124:77node_modules/@.../dom/dist/wait-for.js:82:9
src/pages/MembersPage/MembersActivation/MembersActivation.test.jsx > Members Activation > MemberActivation > user is currently on a trial > plan auto activate is not undefined > does not render auto activate component
Stack Traces | 0.0321s run time
Error: expect(element).not.toBeInTheDocument()

expected document not to contain element, found <div
  class="border-2 border-ds-gray-primary"
>
  Activation
  <hr
    class="mx-4"
  />
  AutoActivate
</div> instead
 ❯ .../MembersPage/MembersActivation/MembersActivation.test.jsx:148:36
src/pages/AccountSettings/tabs/OrgUploadToken/TokenlessSection/TokenlessSection.test.tsx > TokenlessSection > when "Required" option is selected > renders the "Cancel" button
Stack Traces | 1.12s run time
TestingLibraryElementError: Unable to find role="button" and name `/Cancel/`

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="border border-ds-gray-secondary bg-ds-container"
    >
      <div
        class="border-b border-ds-gray-secondary p-5"
      >
        <div
          class="flex items-center gap-2"
        >
          <h2
            class="text-sm font-semibold"
          >
            Token authentication for public repositories
          </h2>
          <a
            class="
  font-sans cursor-pointer

  hover:underline

  focus:ring-2
 text-ds-blue-default inline-flex items-center gap-1"
            data-cy="tokenlessDocs"
            data-marketing="tokenlessDocs"
            href="https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token"
            target="_blank"
          >
            <span
              class="text-ds-primary"
            >
              learn more
            </span>
            <span
              class="text-ds-gray-quinary"
            >
              <svg
                class="w-4 h-4"
                data-icon=""
                data-testid=""
                fill="none"
                stroke="currentColor"
                viewBox="0 0 24 24"
                xmlns="http://www.w3.org/2000/svg"
              >
                <path
                  d="M10 6H6a2 2 0 00-2 2v10a2 2 0 002 2h10a2 2 0 002-2v-4M14 4h6m0 0v6m0-6L10 14"
                  stroke-linecap="round"
                  stroke-linejoin="round"
                  stroke-width="2"
                />
              </svg>
            </span>
          </a>
        </div>
      </div>
      <div
        class="m-5"
      >
        <p
          class="mb-3"
        >
          Select an authentication option
        </p>
        <div
          aria-required="false"
          class="flex gap-4 flex-row"
          dir="ltr"
          role="radiogroup"
          style="outline: none;"
          tabindex="0"
        >
          <button
            aria-checked="true"
            class="relative flex-1"
            data-radix-collection-item=""
            data-state="checked"
            data-testid="token-not-required-radio"
            id=":rk:"
            role="radio"
            tabindex="-1"
            type="button"
            value="not-required"
          >
            <div
              class="flex h-full flex-col justify-center gap-2 rounded-md border border-ds-gray-quaternary p-4"
            >
              <div
                class="relative flex items-center justify-between gap-4"
              >
                <label
                  class="text-left font-medium"
                  for=":rk:"
                >
                  Not required
                </label>
                <div
                  class="size-4 flex-none rounded-full border border-ds-gray-quaternary"
                  data-testid="radio-button-circle-unselected"
                />
                <span
                  class="absolute right-0"
                  data-state="checked"
                >
                  <div
                    class="flex size-4 items-center justify-center rounded-full bg-ds-blue-darker"
                  >
                    <div
                      class="size-1 rounded-full bg-ds-container"
                      data-testid="radio-button-circle-selected"
                    />
                  </div>
                </span>
              </div>
              <p
                class="text-left text-ds-gray-quinary"
              >
                When a token is not required, your team can upload coverage reports without one. Existing tokens will still work, and no action is needed for past uploads.
              </p>
            </div>
            <span
              class="absolute right-0 top-0 size-full rounded-md border-2 border-ds-blue-darker"
              data-state="checked"
            />
          </button>
          <button
            aria-checked="false"
            class="relative flex-1"
            data-radix-collection-item=""
            data-state="unchecked"
            data-testid="token-required-radio"
            id=":rm:"
            role="radio"
            tabindex="0"
            type="button"
            value="required"
          >
            <div
              class="flex h-full flex-col justify-center gap-2 rounded-md border border-ds-gray-quaternary p-4"
            >
              <div
                class="relative flex items-center justify-between gap-4"
              >
                <label
                  class="text-left font-medium"
                  for=":rm:"
                >
                  Required
                </label>
                <div
                  class="size-4 flex-none rounded-full border border-ds-gray-quaternary"
                  data-testid="radio-button-circle-unselected"
                />
              </div>
              <p
                class="text-left text-ds-gray-quinary"
              >
                When a token is required, your team must use a global or repo-specific token for uploads.
              </p>
            </div>
          </button>
        </div>
      </div>
    </div>
  </div>
</body>

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="border border-ds-gray-secondary bg-ds-container"
    >
      <div
        class="border-b border-ds-gray-secondary p-5"
      >
        <div
          class="flex items-center gap-2"
        >
          <h2
            class="text-sm font-semibold"
          >
            Token authentication for public repositories
          </h2>
          <a
            class="
  font-sans cursor-pointer

  hover:underline

  focus:ring-2
 text-ds-blue-default inline-flex items-center gap-1"
            data-cy="tokenlessDocs"
            data-marketing="tokenlessDocs"
            href="https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token"
            target="_blank"
          >
            <span
              class="text-ds-primary"
            >
              learn more
            </span>
            <span
              class="text-ds-gray-quinary"
            >
              <svg
                class="w-4 h-4"
                data-icon=""
                data-testid=""
                fill="none"
                stroke="currentColor"
                viewBox="0 0 24 24"
                xmlns="http://www.w3.org/2000/svg"
              >
                <path
                  d="M10 6H6a2 2 0 00-2 2v10a2 2 0 002 2h10a2 2 0 002-2v-4M14 4h6m0 0v6m0-6L10 14"
                  stroke-linecap="round"
                  stroke-linejoin="round"
                  stroke-width="2"
                />
              </svg>
            </span>
          </a>
        </div>
      </div>
      <div
        class="m-5"
      >
        <p
          class="mb-3"
        >
          Select an authentication option
        </p>
        <div
          aria-required="false"
          class="flex gap-4 flex-row"
          dir="ltr"
          role="radiogroup"
          style="outline: none;"
          tabindex="0"
        >
          <button
            aria-checked="true"
            class="relative flex-1"
            data-radix-collection-item=""
            data-state="checked"
            data-testid="token-not-required-radio"
            id=":rk:"
            role="radio"
            tabindex="-1"
            type="button"
            value="not-required"
          >
            <div
              class="flex h-full flex-col justify-center gap-2 rounded-md border border-ds-gray-quaternary p-4"
            >
              <div
                class="relative flex items-center justify-between gap-4"
              >
                <label
                  class="text-left font-medium"
                  for=":rk:"
                >
                  Not required
                </label>
                <div
                  class="size-4 flex-none rounded-full border border-ds-gray-quaternary"
                  data-testid="radio-button-circle-unselected"
                />
                <span
                  class="absolute right-0"
                  data-state="checked"
                >
                  <div
                    class="flex size-4 items-center justify-center rounded-full bg-ds-blue-darker"
                  >
                    <div
                      class="size-1 rounded-full bg-ds-container"
                      data-testid="radio-button-circle-selected"
                    />
                  </div>
                </span>
              </div>
              <p
                class="text-left text-ds-gray-quinary"
              >
                When a token is not required, your team can upload coverage reports without one. Existing tokens will still work, and no action is needed for past uploads.
              </p>
            </div>
            <span
              class="absolute right-0 top-0 size-full rounded-md border-2 border-ds-blue-darker"
              data-state="checked"
            />
          </button>
          <button
            aria-checked="false"
            class="relative flex-1"
            data-radix-collection-item=""
            data-state="unchecked"
            data-testid="token-required-radio"
            id=":rm:"
            role="radio"
            tabindex="0"
            type="button"
            value="required"
          >
            <div
              class="flex h-full flex-col justify-center gap-2 rounded-md border border-ds-gray-quaternary p-4"
            >
              <div
                class="relative flex items-center justify-between gap-4"
              >
                <label
                  class="text-left font-medium"
                  for=":rm:"
                >
                  Required
                </label>
                <div
                  class="size-4 flex-none rounded-full border border-ds-gray-quaternary"
                  data-testid="radio-button-circle-unselected"
                />
              </div>
              <p
                class="text-left text-ds-gray-quinary"
              >
                When a token is required, your team must use a global or repo-specific token for uploads.
              </p>
            </div>
          </button>
        </div>
      </div>
    </div>
  </div>
</body>waitForWrapper node_modules/@.../dom/dist/wait-for.js:163:27node_modules/@.../dom/dist/query-helpers.js:86:33
 ❯ .../OrgUploadToken/TokenlessSection/TokenlessSection.test.tsx:165:41

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Mar 13, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
bba6c1b Thu, 13 Mar 2025 08:08:12 GMT Expired Expired
d4f617e Mon, 17 Mar 2025 18:55:47 GMT Expired Expired
59275d6 Tue, 18 Mar 2025 22:22:39 GMT Expired Expired
6f8e498 Mon, 24 Mar 2025 23:01:18 GMT Cloud Enterprise

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no test for this that should also go? If not all g just confirming

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't have a test to check the existence of the link, just the text 🫣

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok lol sounds good 🙈

Copy link
Contributor

sentry-autofix bot commented Mar 17, 2025

✅ Sentry found no issues in your recent changes ✅

@codecov-staging
Copy link

codecov-staging bot commented Mar 17, 2025

Bundle Report

Changes will decrease total bundle size by 89 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.11MB -42 bytes (-0.0%) ⬇️
gazebo-staging-esm 6.19MB -47 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js -47 bytes 12.29kB -0.38%

Files in assets/index.*.js:

  • ./src/pages/RepoPage/CommitsTab/CommitsTable/Title/Title.tsx → Total Size: 1.69kB
view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js -42 bytes 11.39kB -0.37%

Files in assets/index-legacy.*.js:

  • ./src/pages/RepoPage/CommitsTab/CommitsTable/Title/Title.tsx → Total Size: 1.69kB

@codecov-notifications
Copy link

codecov-notifications bot commented Mar 17, 2025

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
4237 4 4233 2
View the top 3 failed test(s) by shortest run time
src/shared/GlobalTopBanners/TrialBanner/TrialBanner.test.tsx > TrialBanner > owner does not belong to org > renders nothing
Stack Traces | 0.0239s run time
AssertionError: expected 1 to be +0 // Object.is equality

Ignored nodes: comments, script, style
<html>
  <head />
  <body>
    <div />
  </body>
</html>

- Expected
+ Received

- 0
+ 1

 ❯ .../GlobalTopBanners/TrialBanner/TrialBanner.test.tsx:249:60runWithExpensiveErrorDiagnosticsDisabled node_modules/@.../dom/dist/config.js:47:12checkCallback node_modules/@.../dom/dist/wait-for.js:124:77node_modules/@.../dom/dist/wait-for.js:82:9
src/pages/MembersPage/MembersActivation/MembersActivation.test.jsx > Members Activation > MemberActivation > user is currently on a trial > plan auto activate is not undefined > does not render auto activate component
Stack Traces | 0.0321s run time
Error: expect(element).not.toBeInTheDocument()

expected document not to contain element, found <div
  class="border-2 border-ds-gray-primary"
>
  Activation
  <hr
    class="mx-4"
  />
  AutoActivate
</div> instead
 ❯ .../MembersPage/MembersActivation/MembersActivation.test.jsx:148:36
src/services/commit/useCommit.test.tsx > useCommit > when useCommit is called > api returns valid response > returns commit info
Stack Traces | 1.08s run time
AssertionError: expected { commit: { …(12) } } to deeply equal { commit: { author: { …(1) }, …(11) } }

Ignored nodes: comments, script, style
<html>
  <head />
  <body>
    <div />
  </body>
</html>

- Expected
+ Received

  Object {
    "commit": Object {
      "author": Object {
        "username": "febg",
      },
      "branchName": null,
      "ciPassed": true,
      "commitid": "f00162848a3cebc0728d915763c2fd9e92132408",
-     "compareWithParent": Object {
-       "__typename": "Comparison",
-       "directChangedFilesCount": 1,
-       "impactedFiles": Object {
-         "__typename": "ImpactedFiles",
-         "results": Array [],
-       },
-       "indirectChangedFilesCount": 1,
-       "patchTotals": null,
-       "state": "pending",
-     },
+     "compareWithParent": undefined,
      "coverageAnalytics": Object {
        "totals": Object {
          "coverage": 38.30846,
        },
      },
      "createdAt": "2020-08-25T16:35:32",
      "message": "paths test",
      "parent": Object {
        "commitid": "d773f5bc170caec7f6e64420b0967e7bac978a8f",
        "coverageAnalytics": Object {
          "totals": Object {
            "coverage": 38.30846,
          },
        },
      },
      "pullId": 10,
      "state": "complete",
      "uploads": Array [
        Object {
          "buildCode": null,
          "ciUrl": "https://travis-ci..../repo-test/jobs/721065746",
          "createdAt": "2020-08-25T16:36:19.55947400:00",
          "downloadUrl": ".../repo-test/download/build?path=.../F84D6D9A7F883055E40E3B380280BC44/f00162848a3cebc0728d915763c2fd9e92132408/30582d33-de37-4272-ad50-c4dc805802fb.txt",
          "errors": Array [],
          "flags": Array [],
          "id": 0,
          "jobCode": null,
          "name": "upload name",
          "provider": "travis",
          "state": "PROCESSED",
          "updatedAt": "2020-08-25T16:36:19.67986800:00",
          "uploadType": "UPLOADED",
        },
        Object {
          "buildCode": null,
          "ciUrl": "https://travis-ci..../repo-test/jobs/721065763",
          "createdAt": "2020-08-25T16:36:25.82034000:00",
          "downloadUrl": ".../repo-test/download/build?path=.../F84D6D9A7F883055E40E3B380280BC44/f00162848a3cebc0728d915763c2fd9e92132408/18b19f8d-5df6-48bd-90eb-50578ed8812f.txt",
          "errors": Array [],
          "flags": Array [],
          "id": 1,
          "jobCode": null,
          "name": "upload name",
          "provider": "travis",
          "state": "PROCESSED",
          "updatedAt": "2020-08-25T16:36:25.85988900:00",
          "uploadType": "UPLOADED",
        },
      ],
    },
  }

 ❯ .../services/commit/useCommit.test.tsx:412:57runWithExpensiveErrorDiagnosticsDisabled node_modules/@.../dom/dist/config.js:47:12checkCallback node_modules/@.../dom/dist/wait-for.js:124:77Timeout.checkRealTimersCallback node_modules/@.../dom/dist/wait-for.js:118:16

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@codecov-qa
Copy link

codecov-qa bot commented Mar 18, 2025

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
3634 3 3631 0
View the top 3 failed test(s) by shortest run time
src/shared/GlobalTopBanners/TrialBanner/TrialBanner.test.tsx > TrialBanner > owner does not belong to org > renders nothing
Stack Traces | 0.0239s run time
AssertionError: expected 1 to be +0 // Object.is equality

Ignored nodes: comments, script, style
<html>
  <head />
  <body>
    <div />
  </body>
</html>

- Expected
+ Received

- 0
+ 1

 ❯ .../GlobalTopBanners/TrialBanner/TrialBanner.test.tsx:249:60runWithExpensiveErrorDiagnosticsDisabled node_modules/@.../dom/dist/config.js:47:12checkCallback node_modules/@.../dom/dist/wait-for.js:124:77node_modules/@.../dom/dist/wait-for.js:82:9
src/pages/MembersPage/MembersActivation/MembersActivation.test.jsx > Members Activation > MemberActivation > user is currently on a trial > plan auto activate is not undefined > does not render auto activate component
Stack Traces | 0.0321s run time
Error: expect(element).not.toBeInTheDocument()

expected document not to contain element, found <div
  class="border-2 border-ds-gray-primary"
>
  Activation
  <hr
    class="mx-4"
  />
  AutoActivate
</div> instead
 ❯ .../MembersPage/MembersActivation/MembersActivation.test.jsx:148:36
src/services/commit/useCommit.test.tsx > useCommit > when useCommit is called > api returns valid response > returns commit info
Stack Traces | 1.08s run time
AssertionError: expected { commit: { …(12) } } to deeply equal { commit: { author: { …(1) }, …(11) } }

Ignored nodes: comments, script, style
<html>
  <head />
  <body>
    <div />
  </body>
</html>

- Expected
+ Received

  Object {
    "commit": Object {
      "author": Object {
        "username": "febg",
      },
      "branchName": null,
      "ciPassed": true,
      "commitid": "f00162848a3cebc0728d915763c2fd9e92132408",
-     "compareWithParent": Object {
-       "__typename": "Comparison",
-       "directChangedFilesCount": 1,
-       "impactedFiles": Object {
-         "__typename": "ImpactedFiles",
-         "results": Array [],
-       },
-       "indirectChangedFilesCount": 1,
-       "patchTotals": null,
-       "state": "pending",
-     },
+     "compareWithParent": undefined,
      "coverageAnalytics": Object {
        "totals": Object {
          "coverage": 38.30846,
        },
      },
      "createdAt": "2020-08-25T16:35:32",
      "message": "paths test",
      "parent": Object {
        "commitid": "d773f5bc170caec7f6e64420b0967e7bac978a8f",
        "coverageAnalytics": Object {
          "totals": Object {
            "coverage": 38.30846,
          },
        },
      },
      "pullId": 10,
      "state": "complete",
      "uploads": Array [
        Object {
          "buildCode": null,
          "ciUrl": "https://travis-ci..../repo-test/jobs/721065746",
          "createdAt": "2020-08-25T16:36:19.55947400:00",
          "downloadUrl": ".../repo-test/download/build?path=.../F84D6D9A7F883055E40E3B380280BC44/f00162848a3cebc0728d915763c2fd9e92132408/30582d33-de37-4272-ad50-c4dc805802fb.txt",
          "errors": Array [],
          "flags": Array [],
          "id": 0,
          "jobCode": null,
          "name": "upload name",
          "provider": "travis",
          "state": "PROCESSED",
          "updatedAt": "2020-08-25T16:36:19.67986800:00",
          "uploadType": "UPLOADED",
        },
        Object {
          "buildCode": null,
          "ciUrl": "https://travis-ci..../repo-test/jobs/721065763",
          "createdAt": "2020-08-25T16:36:25.82034000:00",
          "downloadUrl": ".../repo-test/download/build?path=.../F84D6D9A7F883055E40E3B380280BC44/f00162848a3cebc0728d915763c2fd9e92132408/18b19f8d-5df6-48bd-90eb-50578ed8812f.txt",
          "errors": Array [],
          "flags": Array [],
          "id": 1,
          "jobCode": null,
          "name": "upload name",
          "provider": "travis",
          "state": "PROCESSED",
          "updatedAt": "2020-08-25T16:36:25.85988900:00",
          "uploadType": "UPLOADED",
        },
      ],
    },
  }

 ❯ .../services/commit/useCommit.test.tsx:412:57runWithExpensiveErrorDiagnosticsDisabled node_modules/@.../dom/dist/config.js:47:12checkCallback node_modules/@.../dom/dist/wait-for.js:124:77Timeout.checkRealTimersCallback node_modules/@.../dom/dist/wait-for.js:118:16

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Gazebo] Clicking commit author name in commits list takes to org's owner page
3 participants