Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and simplify notification logic a bit #1185

Merged
merged 3 commits into from
Mar 31, 2025
Merged

Conversation

Swatinem
Copy link
Contributor

Also fixes a few type errors while I was at it.

@Swatinem Swatinem requested a review from a team March 28, 2025 10:52
@Swatinem Swatinem self-assigned this Mar 28, 2025
Copy link
Contributor

✅ Sentry found no issues in your recent changes ✅

@Swatinem Swatinem force-pushed the swatinem/refactor-notify branch from 2df1369 to 94a0697 Compare March 28, 2025 10:56
Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥔🥔

@Swatinem Swatinem force-pushed the swatinem/refactor-notify branch from f186003 to f3d63d1 Compare March 31, 2025 07:44
@codecov-notifications
Copy link

codecov-notifications bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/notification/__init__.py 96.29% 1 Missing ⚠️
services/notification/commit_notifications.py 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.71%. Comparing base (e932541) to head (8e70aab).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/notification/__init__.py 96.29% 1 Missing ⚠️
services/notification/commit_notifications.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1185      +/-   ##
==========================================
- Coverage   97.71%   97.71%   -0.01%     
==========================================
  Files         455      455              
  Lines       37205    37200       -5     
==========================================
- Hits        36354    36349       -5     
  Misses        851      851              
Flag Coverage Δ
integration 42.76% <77.77%> (-0.01%) ⬇️
unit 90.54% <94.44%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Swatinem Swatinem added this pull request to the merge queue Mar 31, 2025
Merged via the queue into main with commit 20eb6c5 Mar 31, 2025
26 of 29 checks passed
@Swatinem Swatinem deleted the swatinem/refactor-notify branch March 31, 2025 08:58
Copy link

sentry-io bot commented Apr 2, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ KeyError: 'type' app.tasks.notify.Notify View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants