Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Move crds to sub folder #511

Closed
wants to merge 5 commits into from

Conversation

jvcdk
Copy link
Contributor

@jvcdk jvcdk commented Mar 24, 2025

This builds on top of PR #510. If #510 is approved / merged, I will rebase this PR. But I add it here now to start a conversation :)

I suggest moving the CRDs into a subfolder crds. Motivation: Separate content (CRDs) from supporting elements, and thus keeping a better overview.

@eyarz: Does this interfere with something in your setup / something on your side?

@jvcdk
Copy link
Contributor Author

jvcdk commented Mar 31, 2025

Hi @eyarz

Would you comment on this PR before I put more work into it to bring it up-to-date?

BR
Jørn

@eyarz
Copy link
Member

eyarz commented Apr 1, 2025

I think you will make a lot of people mad because you will break their pipeline that is directed to look for the CRDs at https://raw.githubusercontent.com/datreeio/CRDs-catalog/main/{{.Group}}/{{.ResourceKind}}_{{.ResourceAPIVersion}}.json

@jvcdk
Copy link
Contributor Author

jvcdk commented Apr 3, 2025

I think you will make a lot of people mad because you will break their pipeline that is directed to look for the CRDs at https://raw.githubusercontent.com/datreeio/CRDs-catalog/main/{{.Group}}/{{.ResourceKind}}_{{.ResourceAPIVersion}}.json

I see.

@jvcdk jvcdk closed this Apr 3, 2025
@jvcdk jvcdk deleted the move-crds-to-sub-folder branch April 3, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants