-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[build] Standardize docker image tarball suffixes for architectures #224969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Previously amd64 images didn't have a suffix, and arm64 images were suffixed with aarch64. This updates all references to use amd64 or arm64. Closes elastic#222990
Pinging @elastic/kibana-operations (Team:Operations) |
buildkite test this |
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it's worth standardizing all the artifact names not just the Docker images at this point?
I'll leave this for @alina-bacalete. The one exception I'm aware of is aarch64 should be used by convention for rpm packages. |
Hello! I don't have a strong opinion on standardizing all the artifact names besides the Docker images, I do believe we should strive for consistency and standard naming conventions across products, but ultimately I think this is a decision for your team to make. Thank you for raising the PR! Please see here the related infra PR for these changes: https://github.com/elastic/infra/pull/42183 and let's sync when merging to be sure we have all the pieces in place. TIA! |
Previously amd64 images didn't have a suffix, and arm64 images were suffixed with aarch64. This updates all references to use amd64 or arm64.
Closes #222990