Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1210
Will be structured into sub-PRs that merge into this branch
enable_logs
logger
module with functions likesentry_logger_trace("Log number %i : %s", 3, "I'm logged up")
feat(logs): add sentry log API + send first logs #1272sentry_value_t
objects containing{name, value}
tuples, allowing us to make use ofsentry.message.parameter.X
to the fullest extent (and not just relying on parameter index). Example API would look likesentry_log_info("some %d data %p that we substitute %s", my_list);
where we then extract objects frommy_list
(asentry_value_t
list) to construct the string & store the named parameters.logs
list (and it goes over the max)sentry_bgworker
and flush every 5sbgworker
should only start when logs are enabledbefore_send_log
callbacktrace_id
andspan_id
Also, next to the initial implementation some future work remains. These should become their own issues after this PR is finished (and the merit to these improvements has been discussed as being worthwhile to implement)
sentry__logger_func()
(e.g.SENTRY_WARNF()
) ❗ (could be part of initial feature release, but consider cost; should people 'pay' for logs created by sdk internals? (more useful to us for debugging))#skip-changelog for now