-
Notifications
You must be signed in to change notification settings - Fork 239
docs: Add endpoint to AWSConfig in readme #1569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
It looks like a lot of changes! What exactly are you trying to merge in? I wonder if you need to merge in the latest version of grafana:master
into your working branch on your fork first.
Hi @ankur22, yes definitely not the intention 🙂 Did a clean check-out and cherry-picked my 🤏 change on top of it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, would be good to get another reviewer to approve, maybe @oleiade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, much appreciated 🙇🏻
@oleiade Pleasure! Thank you for accepting it 🙂 |
@jdbaldry @robbymilo do you know why zizmor is failing on this PR? :( |
What?
Add
endpoint
to theAWSConfig
configuration. The AWSendpoint
is useful to configure when testing locally e.g. against localstack.Checklist
I have used a meaningful title for the PR.
I have described the changes I've made in the "What?" section above.
I have performed a self-review of my changes.
I have run the
npm start
command locally and verified that the changes look good.I have made my changes in the
docs/sources/next
folder of the documentation.Related PR(s)/Issue(s)