Skip to content

docs: Add endpoint to AWSConfig in readme #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

schalksnyman
Copy link

What?

Add endpoint to the AWSConfig configuration. The AWS endpoint is useful to configure when testing locally e.g. against localstack.

Checklist

  • I have used a meaningful title for the PR.

  • I have described the changes I've made in the "What?" section above.

  • I have performed a self-review of my changes.

  • I have run the npm start command locally and verified that the changes look good.

  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2024

CLA assistant check
All committers have signed the CLA.

@schalksnyman schalksnyman requested review from a team as code owners July 2, 2025 07:30
@schalksnyman schalksnyman requested review from going-confetti, e-fisher, ankur22 and AgnesToulet and removed request for a team July 2, 2025 07:30
Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

It looks like a lot of changes! What exactly are you trying to merge in? I wonder if you need to merge in the latest version of grafana:master into your working branch on your fork first.

@schalksnyman
Copy link
Author

Hi @ankur22, yes definitely not the intention 🙂 Did a clean check-out and cherry-picked my 🤏 change on top of it.

Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would be good to get another reviewer to approve, maybe @oleiade?

@heitortsergent heitortsergent requested review from oleiade and removed request for going-confetti and e-fisher July 3, 2025 16:40
@heitortsergent heitortsergent added Area: OSS Content Improvements or additions to community/oss documentation type/docs labels Jul 3, 2025
Copy link
Contributor

@oleiade oleiade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, much appreciated 🙇🏻

@schalksnyman
Copy link
Author

@oleiade Pleasure! Thank you for accepting it 🙂

@heitortsergent
Copy link
Collaborator

@jdbaldry @robbymilo do you know why zizmor is failing on this PR? :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OSS Content Improvements or additions to community/oss documentation type/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants