Fix SongGeneration download count rule #1554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wauplin
requested review from
SBrandeis,
gary149,
julien-c,
pcuenca and
ngxson
as code owners
|
Thank you for catching this typo! Please consider reviewing and merging this PR. @xianbaoqian @Vaibhavs10 |
|
(I'm actually merging it now, hope you don't mind :)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR after #1542 cc @juhayna-zh @xianbaoqian @Vaibhavs10
There seems to be a typo in the download count rule. Checkpoint is saved at https://huggingface.co/tencent/SongGeneration/blob/main/ckpt/songgeneration_base/model.pt (under
songgeneration_base, notsonggeneration_base_zh). This PR fixes this.(I also took the opportunity to update
repoName, it's usually best if it's the same asprettyLabel)