perf: reduce DBSearchPage and DBChartExplorerPage rerenders from typing in search input #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
knudtty
commented
Jun 11, 2025
Comment on lines
+968
to
+979
| const aliasWith = useMemo( | ||
| () => | ||
| Object.entries(aliasMap ?? {}).map(([key, value]) => ({ | ||
| name: key, | ||
| sql: { | ||
| sql: value, | ||
| params: {}, | ||
| }, | ||
| isSubquery: false, | ||
| })), | ||
| [aliasMap], | ||
| ); |
There was a problem hiding this comment.
This was a major culprit, because histogramTimeChartConfig relies on it and was the main cause of an expensive rerender of DBTimeChart every keypress.
🦋 Changeset detectedLatest commit: faf0877 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
knudtty
changed the title
teeohhem
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes HDX-1771
DBSearchPage rerender time for a keypress in the search input went from 46ms -> 4ms
