Fixes reset_joints_by_scale and reset_joints_by_offsets to only affect the joint_names specified in SceneEntityCfg #2803
+33
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ooctipus
requested review from
jsmith-bdai,
kellyguo11 and
Mayankm96
as code owners
kellyguo11
changed the title
|
Seems like a bunch of the CI tests are failing/timing out, we could maybe try resolving the conflicts and re-running the tests on the latest? |
ooctipus
force-pushed
the
fix/reset_joints_by_offsets_not_indicing_joint
branch
from
6d30e89 to
defde0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both reset_joints_by_offsets and reset_joints_by_scale ignores the joint_ids specified in SceneEntityCfg passed through asset_cfg and affects all joints.
This bug is affecting all cartpole environments.
After the fix the functions are restricted to only reset the joint specified through SceneEntityCfg, Cartpole environment runs and reset behaves correctly
Fixes #2800 #980 #1742
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there