-
Notifications
You must be signed in to change notification settings - Fork 2k
✨ feat(Ray): Enhance Ray #2847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
✨ feat(Ray): Enhance Ray #2847
Conversation
Add task_runner.py to support specifying resources, py_modules, and pip. isaac-sim#2632
@ozhanozen @garylvov I have added task_runner.py as an additional method for submitting jobs. This method supports specifying resources, py_modules, and pip dependencies. If you have time, could you please help review the code? Thank you! |
Hi I will review by the end of this weekend please ping me if no activity within 1 week |
|
||
YAML configuration example: | ||
--------------------------- | ||
.. code-block:: yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: can you show a real example in a config file as well if possible? Maybe will make this example a bit more clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the most recent commit, I have updated the comments and included an official example from IsaacLab for multi-GPU training. This may help clarify the usage.
return True | ||
|
||
|
||
def submit_tasks(ray_address,pip,py_modules,tasks): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to https://github.com/binw666/IsaacLab/blob/752be19bade88c1f1e2a06a1ca6519baafbba216/scripts/reinforcement_learning/ray/submit_job.py#L79 seems like duplicate logic that could be unified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does resemble the submit_job function in submit_job.py, but it serves a different purpose. Here, the function calls remote to execute, whereas submit_job submits tasks via client.submit_job. Do you have any better suggestions?
Hi @binw666 thank you for the PR please let me know if you have any questions about my comments I'm happy to help. Once you address these issues just rerequest me for the review or @ me and I'll check it out again. Thanks! |
@garylvov Thank you very much for your review. I have updated the code and documentation to address the above issues. |
@binw666, I don't have a HW currently that I can use to test the functionality of the PR, but I try to give feedback on other stuff as much as possible. I noticed that some of the highlighted line numbers of the file |
I’m not sure if this PR is the right place to bring this up or if it should be addressed in a separate one, but based on my experience, I believe the current Ray integration is missing a key feature: support for a custom Right now, the integration defaults to the standard What do you think about this? |
That being said, it's probably quickest to include that functionality in this PR in terms of getting things merged into main |
Description
This PR:
Fixes # (issue)
Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there