efa: Fix CQ poll after QP destroy #1616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a QP has been destroyed there might still be pending CQEs. As an optimization for some cases, poll functions ignore CQs that are not in use by any QP, preventing completions from being read after destruction of the last QP that uses this CQ. Remove this optimization. Reviewed-by: Firas Jahjah <firasj@amazon.com> Signed-off-by: Michael Margolin <mrgolin@amazon.com>
mrgolin
force-pushed
the
poll-after-qp-destroy
branch
from
2e8ad62 to
3f02277
Compare
|
@jgunthorpe @rleon Can we please merge this small change? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Unbreaking the CI was a Microsoft adventure of "It does not work" errors when clicking a button until it finally worked after restarting web browsers to make the button happy again. Sigh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a QP has been destroyed there might still be pending CQEs. As an optimization for some cases, poll functions ignore CQs that are not in use by any QP, preventing completions from being read after destruction of the last QP that uses this CQ. Remove this optimization.