Create static analysis tool for token usage #34108
Conversation
updating to use recursive analysis process through AST Still some bugs
remove output file
adding debug/perf measures
update code to properly output new format simplify types
* Store makeResetStyles lookup * Fix up reset styles * Remove unneeded function * Update analyzer to work on nested tokens * Add mergeStyles variable detection * Update comment * Comment out completed task * Create analysis.json * Update analysis.json * Add data layer based on style function and object name * add assignedvars to all
* Update function call to spec to nested values * Update test and focus style
* Update test to handle focus * Update readme with completed tasks * Update test
* add some module res code and tests * updated module resolver * updates to module resolver * fixing tests removing log * fix tests add import analyzer leverage TS APIs to find aliased values * remove console log. * adding comment updating readme * writing css var analysis tests and ensure failure * uncomment clean up * update readme * adding ability to analyze css vars updating some broken import analysis * fixing import processing for string literals and property accessors * Fix duplication issues in token data adjust tests so we aren't testing for scenarios we can't cover add todo for more complexity/nesting * updating button analysis fixing import for cjs * update README * updating analysis with default format from tool and order * add format to do * some debug comments break template expression handling out separately so we can deal with spans * Format json with prettier automatically. * update to dos * Update so we recurse through imports and template string spans * Adding spread handling updating tests and sample data centralize token detection * fix spread analysis * sorting json output for consistent results updating button analysis update todos
brandonthomas
requested review from
a team,
JustSlone,
jurokapsiar and
tudorpopams
as code owners
.vscode/launch.json
Outdated
There was a problem hiding this comment.
I might actually revert this
|
@brandonthomas IMO contrib looks like a better fit for this kind of projects. @Hotell thoughts? |
I tend to agree, unless there is a reason this needs to be in the build with the core suite package, contrib is a great place to house this, we want to move more things to contrib where we can. |
|
@JustSlone @layershifter I don't mind moving it over since we can run it in CLI and programmatically. I don't think I have any hard deps that would require it be here other than pure convenience. I can shift it over and pull it down in this repo for testing. I'd likely then just add it as a devdep. |
|
Moving all logic into contrib repo. Once published, I'll pull the package as a dev dep and run it here. |
This change adds a static analysis tool based on ts-morph that processes token usage and can map to CSS rules, slots and generate meta data for which states they are applied in. This gives us a powerful set of data to build better tooling, have greater confidence when changes are made, and to help ensure we don't regress the existing token API when we apply semantic tokens across the repository.
Some features this tool has
react-components.nexports, template string literal spans, var fallback chains, Griffel's shorthands and more. We attempted to make this as comprehensive as possible however there may still be some edges left.*.styles.tsnaming convention. We don't process all files for performance reasons.