Skip to content

plugins/no-neck-pain: init #3553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chelsea6502
Copy link

Requesting to add one of my favourite Neovim plugins: No Neck Pain. It centers the buffer to the middle of the screen.

This is my first time contributing to Nixvim, so let me know if there's any conventions I've missed. I assume I will have to add myself as a maintainer?

maintainers = [ lib.maintainers.ChelseaWilkinson ];
packPathName = "no-neck-pain.nvim";
package = "no-neck-pain-nvim";
url = "https://github.com/shortcuts/no-neck-pain.nvim";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url = "https://github.com/shortcuts/no-neck-pain.nvim";

Should be fetched from meta

url = "https://github.com/shortcuts/no-neck-pain.nvim";
description = "☕ Dead simple yet super extensible zen mode plugin to protect your neck.";

moduleName = "no-neck-pain";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
moduleName = "no-neck-pain";

Already defaults to name


defaults = {
plugins.no-neck-pain = {
enable = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add at least some of the defaults from https://github.com/shortcuts/no-neck-pain.nvim/blob/main/lua/no-neck-pain/config.lua#L148-L338 for testing the plugin.

Comment on lines +28 to +33
ChelseaWilkinson = {
email = "mail@chelseawilkinson.me";
github = "chelsea6502";
githubId = 122856043;
name = "Chelsea Wilkinson";
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split this into a separate commit before the addition of the module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants