fix(core): allow any framework value in preset generator schema #31665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 76fa13d.
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
force-pushed
the
fix-custom-plugin
branch
2 times, most recently
from
5794b22 to
4213017
Compare
AgentEnder
approved these changes
Jun 20, 2025
third-party presets can now pass any value for framework, linter, bundler, unitTestRunner, e2eTestRunner, formatter, and packageManager properties without schema validation errors. previously, these properties were restricted to specific enum values, but third-party presets need flexibility to use other tools. fixes issue where npx create-nx-workspace --preset=@rig/cli@alpha --framework=angular would fail with schema validation error.
FrozenPandaz
force-pushed
the
fix-custom-plugin
branch
from
4213017 to
76fa13d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When using third-party presets with
npx create-nx-workspace, passing framework values other than the predefined backend frameworks fails with a schema validation error:For example:
Expected Behavior
Third-party presets should be able to pass any framework value without schema validation errors, allowing for greater flexibility in the Nx ecosystem.
Related Issue(s)
This fixes the issue where third-party presets cannot pass framework values like 'angular', 'react', 'vue', etc., due to overly restrictive schema validation.
Changes
enumconstraint from theframeworkproperty in the workspace preset generator schemaThe built-in Nx preset generators still only handle frameworks they know about, but the schema validation no longer blocks third-party presets from passing other framework values.
Test plan
npx create-nx-workspace --preset=@rig/cli@alpha --framework=angularshould work without schema validation errors