-
Notifications
You must be signed in to change notification settings - Fork 95
Investigate antimeridian improvements and pyproj updates #645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
70f477c
to
559bd7c
Compare
Needs versioneer fixes from #648 |
559bd7c
to
cc4cb05
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #645 +/- ##
=======================================
Coverage 93.98% 93.98%
=======================================
Files 86 86
Lines 13543 13534 -9
=======================================
- Hits 12728 12720 -8
+ Misses 815 814 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@mraspaud @pnuu I'm curious what you guys think about this PR and if I should split it up or go further or I don't know what. The main important change that I wanted was the DynamicAreaDefinition's change to use Do I maybe switch this PR to be just the DynamicAreaDefinition changes? Then do another PR for the future class to drop valid input/output arrays? Then do another PR for the xarray-based class (and maybe the numpy functions) to drop valid input/output? I'm not sure. This doesn't even begin to talk about my real desire which is to explore the XYZ transformation by pyproj changes after all of this (which I have working locally). |
I'd say do the Just a thought on the input/output array stuff perhaps be adapted based on the validity range of the coordinates? I don't remember exactly, but I think at the masking we would know whether the coordinates are from -180 to 180 or from 0 to 360. I'm not say not to remove them if it makes new things possible, just a thought. |
For validity arrays, I think the bottom line, from what I can tell, is that in modern practices they are unnecessary. From the sound of it, most users are probably masking their geolocation already or Satpy is or the input files people are reading do. Or as a last resort the computations by pyproj will make them infinity or NaN. |
I had these changes lying around and needed to get them out of the way. Maybe I'll get back to this soon...for now it is here for comment if people are really really bored.