Skip to content

add download command to cache folder in advance #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

add download command to cache folder in advance #160

merged 1 commit into from
Jun 20, 2025

Conversation

haixuanTao
Copy link
Contributor

To test out:

uv run robot_descriptions download iiwa14_description

@stephane-caron
Copy link
Member

stephane-caron commented Jun 20, 2025 •
edited
Loading

Thank you for proposing this feature 👍

nit: Maybe pull rather than download? The word "download" is already explicit 👌 I just feel "pull" would be consistent with git and other tools like docker or ollama. What do you think?

@coveralls
Copy link

coveralls commented Jun 20, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 15780327442

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.99%
Totals Coverage Status
Change from base Build 15760082148: 0.0%
Covered Lines: 1121
Relevant Lines: 1144
💛 - Coveralls

@haixuanTao
Copy link
Contributor Author

Made the change :)

thanks for the quick review :)

@stephane-caron
Copy link
Member

LGTM, thank you for this contribution 👍

@stephane-caron stephane-caron merged commit 4517227 into robot-descriptions:main Jun 20, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haixuanTao @stephane-caron @coveralls