chore: simplify component pop #16331
Merged
+30
−51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
couple of changes here:
$effect
. whenpop
runs, the current active effect/reaction are the same as they were when the effect was declared, so theset_active_effect
andset_active_reaction
calls are no-ops. By extension, we don't need to stash the current active effect/reaction, and we don't need to wrap the effect creation in a try-catchcomponent_context.e
can just be an array of functions rather than an array of objects — less memory usage for components with effects$effect
because the currentactive_effect
is aBRANCH_EFFECT
, and the currentactive_reaction
isnull
. These conditions do not obtain in any other circumstances. Consequently, we can remove them
flag — it's unnecessary. This saves more memory