Add job_workflow_ref label to listener metrics #4054
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rskmm0chang <rskmm0chang@hatena.ne.jp>
rskmm0chang
requested review from
mumoshu,
toast-gear,
nikola-jokic,
rentziass and
a team
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new label for job workflow references to the listener metrics to address issue #4053 by extending the metric dimensions.
- Added a constant for "job_workflow_ref".
- Updated the exporter to include the job_workflow_ref from jobBase.
Comments suppressed due to low confidence (1)
cmd/ghalistener/metrics/metrics.go:83
- Consider adding test coverage to validate that the job_workflow_ref label is correctly mapped in the metrics exporter.
labelKeyJobWorkflowRef: jobBase.JobWorkflowRef,
Signed-off-by: rskmm0chang <rskmm0chang@hatena.ne.jp>
|
Hi, thank you always for your great maintenance work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #4053