Re-create the listener when GitHub secret is updated #4036
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-jokic
added
the
gha-runner-scale-set
nikola-jokic
requested review from
mumoshu,
toast-gear,
rentziass and
a team
as code owners
controllers/actions.github.com/autoscalingrunnerset_controller_test.go
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the GitHub secret is updated, the change is not reflected in the listener config.
If the GitHub secret is updated, the listener spec hash should be recalculated to reflect the new secret. The listener identity should be defined by its spec and the secret it uses to instantiate the actions client. Therefore, this change should include the secret's spec hash so the entire
AutoscalingListeneris re-created when the secret is updated.Fixes #4029