Fixed nbrech when no schedule. Changed template for debugging. Added 'real' test script.

Author: ekyna

Diff for: src/Action/StatusAction.php

@@ -44,9 +44,11 @@ public function execute($request)
             case "paiement" : // paiement accepté (en Production uniquement)
                 $request->markCaptured();
                 break;
+
             case "Annulation" : // contacter l’émetteur de carte
                 $request->markFailed();
                 break;
+
             default :
                 $request->markUnknown();
         }

Diff for: src/Api/Api.php

@@ -95,7 +95,7 @@ public function createPaymentForm(array $data)
             'contexte_commande' => base64_encode(utf8_encode(json_encode($data['context']))),
         ];
 
-        $fields['nbrech'] = count($data['schedule']);
+        $fields['nbrech'] = (0 < $count = count($data['schedule'])) ? $count : null;
         for ($i = 1; $i < 5; $i++) {
             if (!isset($data['schedule'][$i])) {
                 $fields['dateech' . $i] = null;
@@ -132,6 +132,7 @@ public function createPaymentForm(array $data)
             'action' => $this->getEndpointUrl(static::TYPE_PAYMENT),
             'method' => 'POST',
             'fields' => $fields,
+            'debug'  => $this->config['debug'],
         ];
     }
 

Diff for: src/Api/Options/Assert.php

@@ -49,7 +49,7 @@ public static function string(int $max, bool $required = false): callable
 
             $length = strlen($value);
 
-            return (1 < $length) && ($length <= $max);
+            return (1 <= $length) && ($length <= $max);
         };
     }
 
@@ -78,7 +78,7 @@ public static function integer(int $max, bool $required = false): callable
 
             $length = strlen($value);
 
-            return (1 < $length) && ($length <= $max);
+            return (1 <= $length) && ($length <= $max);
         };
     }
 

Diff for: src/Resources/views/api_request.html.twig

@@ -1,21 +1,27 @@
 {% extends layout ?: "@PayumCore/layout.html.twig" %}
 
-{% block payum_body %}
+{% block payum_body -%}
+    {% if not debug -%}
     <p id="message" style="text-align:center;padding-top:50px;display:none;">
         Vous allez être redirigé vers le site de la banque&hellip;
     </p>
+    {%- endif %}
     <form action="{{ action|raw }}" method="{{ method }}" name="MoneticoPaymentForm" id="MoneticoPaymentForm">
         {% for name, value in fields -%}
         <input type="hidden" name="{{ name }}" value="{{ value|raw }}">
         {%- endfor %}
-        <noscript>
+        {% if not debug %}<noscript>{% endif -%}
             <p style="text-align:center;padding-top:50px;">
-                <button id="submit" type="submit" value="Continuer vers le site de la banque"></button>
+                <button id="submit" type="submit">
+                    Continuer vers le site de la banque
+                </button>
             </p>
-        </noscript>
+        {%- if not debug %}</noscript>{% endif %}
     </form>
+    {% if not debug -%}
     <script type="application/javascript">
         document.getElementById('message').style.display = 'block';
         document.getElementById('MoneticoPaymentForm').submit();
     </script>
+    {%- endif %}
 {% endblock %}

Diff for: tests/Api/ApiTest.php

@@ -104,15 +104,16 @@ public function test_create_payment_form()
                 'montantech2'       => null,
                 'montantech3'       => null,
                 'montantech4'       => null,
-                'nbrech'            => 0,
+                'nbrech'            => null,
                 'reference'         => '100008783',
                 'societe'           => 'foobar',
                 'texte-libre'       => 'Commande 100008783',
                 'url_retour_ok'     => 'http://example.org',
                 'url_retour_err'    => 'http://example.org',
                 'version'           => '3.0',
-                'MAC'               => '14ea2a9f24e2ce030889a8176f0cf2c87abf5a10',
+                'MAC'               => '2ea1cd9bd82fbcbf5edf29c18e0269e6e5d7f86a',
             ],
+            'debug' => false,
         ];
 
         $this->assertEquals($expected, $actual);

Diff for: tests/test.php

@@ -0,0 +1,66 @@
+<?php
+
+/*
+ * Use this script to test your credentials.
+ * 'php -S localhost:8000' to start a web server.
+ */
+
+require __DIR__ . '/bootstrap.php';
+
+use Ekyna\Component\Payum\Monetico\MoneticoGatewayFactory;
+use Ekyna\Component\Payum\Monetico\Request\PaymentForm;
+use League\Uri\Http;
+use Payum\Core\Model\Payment;
+use Payum\Core\PayumBuilder;
+use Payum\Core\Reply\HttpResponse;
+
+$paymentClass = Payment::class;
+
+$defaultConfig = [
+    'mode'    => '',
+    'tpe'     => '',
+    'key'     => '',
+    'company' => '',
+    'debug'   => true,
+];
+
+/** @var \Payum\Core\Payum $payum */
+$payum = (new PayumBuilder())
+    ->addDefaultStorages()
+    ->addGatewayFactory('monetico', new MoneticoGatewayFactory($defaultConfig))
+    ->addGateway('monetico', [
+        'factory' => 'monetico',
+        'sandbox' => true,
+    ])
+    ->getPayum();
+
+/** @var \Payum\Core\Gateway $gateway */
+$gateway = $payum->getGateway('monetico');
+
+$uri = Http::createFromServer($_SERVER);
+
+$request = new PaymentForm([
+    'date'        => '25/08/2019:16:30:15',
+    'amount'      => '24.80',
+    'currency'    => 'EUR',
+    'reference'   => '100008784',
+    'comment'     => 'Commande 100008784',
+    'locale'      => 'FR',
+    'email'       => 'test@example.org',
+    'success_url' => (string)$uri->withPath('/done.php'),
+    'failure_url' => (string)$uri->withPath('/done.php'),
+    'context'     => [
+        'billing' => [
+            "addressLine1" => "101 Rue de Roisel",
+            "city"         => "Y",
+            "postalCode"   => "80190",
+            "country"      => "FR",
+        ],
+    ],
+]);
+
+try {
+    $gateway->execute($request);
+} catch (HttpResponse $response) {
+    echo $response->getContent();
+}