Skip to content

Commit ee37fad

Browse files
authored
Merge pull request ekyna#9 from Prometee/symfony-6
Symfony 6.0
2 parents 6dcb00e + c5bf424 commit ee37fad

File tree

3 files changed

+30
-21
lines changed

3 files changed

+30
-21
lines changed

Diff for: .github/workflows/build.yml

+21-7
Original file line numberDiff line numberDiff line change
@@ -16,22 +16,33 @@ jobs:
1616
fail-fast: false
1717
matrix:
1818
php: [7.2, 7.3, 7.4, 8.0]
19-
symfony: [^3.4, ^4.4, ^5.2]
19+
symfony: [^5.4, ^6.0]
20+
21+
exclude:
22+
-
23+
php: 7.2
24+
symfony: ^6.0
25+
-
26+
php: 7.3
27+
symfony: ^6.0
28+
-
29+
php: 7.4
30+
symfony: ^6.0
2031

2132
env:
2233
APP_ENV: test
2334

2435
steps:
2536
-
26-
uses: actions/checkout@v2
37+
uses: actions/checkout@v3
2738

2839
-
2940
name: Setup PHP
3041
uses: shivammathur/setup-php@v2
3142
with:
3243
php-version: "${{ matrix.php }}"
3344
extensions: intl
34-
tools: symfony
45+
tools: flex,symfony
3546
coverage: none
3647

3748
-
@@ -41,22 +52,25 @@ jobs:
4152

4253
-
4354
name: Cache Composer
44-
uses: actions/cache@v2
55+
uses: actions/cache@v3
4556
with:
4657
path: ${{ steps.composer-cache.outputs.dir }}
4758
key: ${{ runner.os }}-php-${{ matrix.php }}-composer-${{ hashFiles('**/composer.json **/composer.lock') }}
4859
restore-keys: |
4960
${{ runner.os }}-php-${{ matrix.php }}-composer-
61+
5062
-
51-
name: Restrict Symfony version
63+
name: Configure global composer
5264
if: matrix.symfony != ''
5365
run: |
54-
composer global require --no-progress --no-scripts --no-plugins "symfony/flex:^1.10"
55-
composer config extra.symfony.require "${{ matrix.symfony }}"
66+
composer global config --no-plugins allow-plugins.symfony/flex true
67+
composer global require --no-progress --no-scripts --no-plugins "symfony/flex"
5668
5769
-
5870
name: Install PHP dependencies
5971
run: composer install --no-interaction
72+
env:
73+
SYMFONY_REQUIRE: ${{ matrix.symfony }}
6074

6175
-
6276
name: Run analysis

Diff for: composer.json

+4-5
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,15 @@
1818
"homepage": "https://github.com/ekyna/PayumMonetico",
1919
"license": "MIT",
2020
"require": {
21-
"php": "^7.2|^8.0",
2221
"ext-json": "*",
2322
"payum/core": "^1.5",
24-
"psr/log": "^1.0|^2.0",
25-
"symfony/options-resolver": "^3.4|^4.4|^5.2",
23+
"psr/log": "^1.0|^3.0",
24+
"symfony/options-resolver": "^5.4|^6.0",
2625
"sokil/php-isocodes": "^2.0|^3.0"
2726
},
2827
"require-dev": {
29-
"php-http/guzzle6-adapter": "^1.1|^2.0",
30-
"phpunit/phpunit": "^7.0|^8.0|^9.0"
28+
"php-http/guzzle7-adapter": "^1.0",
29+
"phpunit/phpunit": "^8.0|^9.0"
3130
},
3231
"autoload": {
3332
"psr-4": {

Diff for: src/Action/Api/AbstractApiAction.php

+5-9
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ abstract class AbstractApiAction implements ActionInterface, GatewayAwareInterfa
3434
/**
3535
* @inheritDoc
3636
*/
37-
public function setApi($api)
37+
public function setApi($api): void
3838
{
3939
if (!$api instanceof Api) {
4040
throw new UnsupportedApiException('Not supported.');
@@ -46,7 +46,7 @@ public function setApi($api)
4646
/**
4747
* {@inheritDoc}
4848
*/
49-
public function setLogger(LoggerInterface $logger)
49+
public function setLogger(LoggerInterface $logger): void
5050
{
5151
$this->logger = $logger;
5252
}
@@ -56,7 +56,7 @@ public function setLogger(LoggerInterface $logger)
5656
*
5757
* @param string $message
5858
*/
59-
protected function log($message)
59+
protected function log(string $message): void
6060
{
6161
if (!$this->logger) {
6262
return;
@@ -67,12 +67,8 @@ protected function log($message)
6767

6868
/**
6969
* Logs the given message and data.
70-
*
71-
* @param string $message
72-
* @param array $data
73-
* @param array $filterKeys
7470
*/
75-
protected function logData($message, array $data, array $filterKeys = [])
71+
protected function logData(string $message, array $data, array $filterKeys = []): void
7672
{
7773
if (!$this->logger) {
7874
return;
@@ -82,7 +78,7 @@ protected function logData($message, array $data, array $filterKeys = [])
8278
$data = array_intersect_key($data, array_flip($filterKeys));
8379
}
8480

85-
$data = array_map(function ($key, $value) {
81+
$data = array_map(static function ($key, $value) {
8682
return "$key: $value";
8783
}, array_keys($data), $data);
8884

0 commit comments

Comments
 (0)