Skip to content

Brew LLVM OpenMP #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aminya opened this issue Mar 17, 2025 · 4 comments · Fixed by #388
Open

Brew LLVM OpenMP #374

aminya opened this issue Mar 17, 2025 · 4 comments · Fixed by #388

Comments

@aminya
Copy link
Owner

aminya commented Mar 17, 2025

After the last release my MacOS pipelines are failing because OpenMP is not found anymore automatically:
https://github.com/flatironinstitute/finufft/actions/runs/13840315537/job/38725974952
This was working until version 1.1.1 flatironinstitute/finufft@dc2931a

Do I need to specify OpenMP to be installed?

Thanks,
Marco

Originally posted by @DiamonDinoia in #335 (comment)

@aminya aminya changed the title Dear @aminya, after the last release my pipelines are failing because OpenMP is not found anymore: Brew LLVM OpenMP Mar 17, 2025
@aminya
Copy link
Owner Author

aminya commented Mar 17, 2025

I wonder if it's because the LLVM installation via brew doesn't include OpenMP. I'll try to test. Could you pin setup-cpp meanwhile?

@DiamonDinoia
Copy link

Hi @aminya,

It seems that I still have problems: https://github.com/DiamonDinoia/finufft/actions/runs/14312541051

Do I need to export LD_LIBRARY_PATH after installing libomp?

Thanks,
Marco

@aminya aminya reopened this Apr 7, 2025
@aminya
Copy link
Owner Author

aminya commented Apr 7, 2025

If the issue still happens, the problem is somewhere else. Needs more investigation.

I disabled the export of the library path due to the conflicts with the system libraries, as the linker automatically picks those libraries. So, only add this if you intend to do so.

@aminya
Copy link
Owner Author

aminya commented Apr 7, 2025

@DiamonDinoia I could configure the project with this. CMake doesn't automatically pick up the homebrew libs.

brew install libomp
cmake -S . -B ./build -G 'Ninja Multi-Config' -DCMAKE_PREFIX_PATH="/opt/homebrew;/opt/homebrew/opt/libomp/"

I'll have to see how we can support this by default. Perhaps I should export LLVM_CMAKE_PREFIX_PATH that you can use in your builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants