Disable csharp tests that use nuget on macos-15 #19234
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR disables a set of csharp tests that use nuget on macos-15 runners due to issues with Mono and nuget provisioning. The changes update the test decorators and comments in multiple test files to indicate that tests should be skipped on macos-15.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| csharp/ql/integration-tests/posix/standalone_dependencies_nuget_no_sources/test.py | Updated test decorator to include macos-15 exclusion |
| csharp/ql/integration-tests/posix/standalone_dependencies_nuget/test.py | Updated test decorator to include macos-15 exclusion |
| csharp/ql/integration-tests/posix/standalone_dependencies_nuget with_space/test.py | Updated test decorator to include macos-15 exclusion |
| csharp/ql/integration-tests/posix/standalone_dependencies_no_framework/test.py | Updated test decorator to include macos-15 exclusion |
Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more
csharp/ql/integration-tests/posix/standalone_dependencies_nuget_no_sources/test.py
Outdated
Show resolved
Hide resolved
csharp/ql/integration-tests/posix/standalone_dependencies_nuget/test.py
Outdated
Show resolved
Hide resolved
| # Skipping the test on the ARM runners, as we're running into trouble with Mono and nuget. | ||
| @pytest.mark.only_if(runs_on.linux or (runs_on.macos and runs_on.x86_64)) | ||
| # Skipping the test on the ARM runners and macos-15, as we're running into trouble with Mono and nuget. | ||
| @pytest.mark.only_if(runs_on.linux or (runs_on.macos and runs_on.x86_64) or (runs_on.macos and not runs_on.macos_15)) |
There was a problem hiding this comment.
The updated decorator does not guarantee that tests will be skipped on macos-15 if the platform qualifies as x86_64. It is recommended to refactor the condition to 'runs_on.linux or (runs_on.macos and runs_on.x86_64 and not runs_on.macos_15)' for clarity and correctness.
| @pytest.mark.only_if(runs_on.linux or (runs_on.macos and runs_on.x86_64) or (runs_on.macos and not runs_on.macos_15)) | |
| @pytest.mark.only_if(runs_on.linux or (runs_on.macos and runs_on.x86_64 and not runs_on.macos_15)) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
csharp/ql/integration-tests/posix/standalone_dependencies_no_framework/test.py
Outdated
Show resolved
Hide resolved
oscarsj
force-pushed
the
oscarsj/csharp-disable-nuget-tests
branch
2 times, most recently
from
81c91c4 to
38ba202
Compare
oscarsj
force-pushed
the
oscarsj/csharp-disable-nuget-tests
branch
from
38ba202 to
5e74bdc
Compare
|
|
||
|
|
||
| # Skipping the test on macos-15, as we're running into trouble. | ||
| @pytest.mark.only_if(not runs_on.macos_15) |
There was a problem hiding this comment.
I think we should investigate a bit more what is happening with this test. The other failing tests are all related to build-mode: none, while this one is an autobuild problem. We have some logic to prefer dotnet msbuild on Apple Silicon, this doesn't seem to match mac os 15, but I think it should.
There was a problem hiding this comment.
Issue filed: https://github.com/github/codeql-csharp-team/issues/475
Could I get an approval while that one is addressed, to move forward with the rest of the macos-15 migration?
csharptests that usenugetdon't seem to be working, possibly due to issues with provisioning ofMonoandnugeton those runners: https://github.com/actions/runner-images/blob/macos-15/20250120.591/images/macos/macos-15-Readme.mdDisabling the tests on that platform for now.