Dark Mode issue#157 #246
Merged
Dark Mode issue#157 #246
+180
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ThemeContext Implemented ThemeContext to provide a light/dark theme. - ThemeToggleButton Added a toggle button to header - _app Refined the structure of Map to now utilize PrimerTheme and ThemeContext to utilize theme change easily. - Header Adding ThemeToggleButton to the header. Fixing UI with flex and div - Header.scss Fixing UI with flex and justify content - package.json Added octicons to utilize theme icons - global.scss utilizing react-primer's built in theming to implement light/dark mode. The global css simply applied using the themeProvider's data-color-mode - ColourStyles.tsx Added in order to override the react-select components to override default styles and follow current theme. - LanguageFilter & SDGFilter Override default react-select style with newly implemented ColourStyles.
|
Sorry for the delay, was waiting for design to sign off :) |
|
@seanmarcia I see that the changes were pushed and later reverted, May I know what changed? was there some issues with the PR? Would love to make necessary changes if required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to enhance the color theming and add a theme toggle button to the application. The most important changes include the creation of a new
ThemeContext, integration of theThemeToggleButton, and updates to various components and styles to support the new theming system.Theming Enhancements:
New ThemeContext:
ThemeContextwith a provider to manage light and dark modes. (context/ThemeContext.tsx)Theme Toggle Button:
ThemeToggleButtoncomponent to allow users to switch between light and dark modes. (components/Header/ThemeToggleButton.tsx)ThemeToggleButtoninto theHeadercomponent. (components/Header/Header.tsx) [1] [2] [3]Color Styles:
ColorStylesfor thereact-selectcomponent to match the new theming system. (components/ColorStyles.tsx)ColorStylestoLanguageFilterandSDGFiltercomponents. (components/LanguageFilter.tsx) [1] [2] (components/SDGFilter.tsx) [3] [4]Component and Style Updates:
Header Component:
Headercomponent to remove thedata-color-modeattribute and use the newThemeContext. (components/Header/Header.tsx)Header.module.scssto improve styling and align items in the header. (components/Header/Header.module.scss) [1] [2]Global Styles:
styles/globals.scss) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]App Component:
Appcomponent to wrap the application with the newThemeProviderand apply the theme context. (pages/_app.tsx) [1] [2]Dependency Updates:
@primer/octicons-reactdependency for theme icons. (package.json)- ThemeContext Implemented ThemeContext to provide a light/dark theme.Fixing UI with flex and div
Should Address issue #157