Skip to content

Revert "Dark Mode issue#157" #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Conversation

seanmarcia
Copy link
Member

Reverts #246

@Copilot Copilot AI review requested due to automatic review settings April 2, 2025 03:03
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts changes related to dark mode functionality by removing the custom ThemeContext, ThemeToggleButton, and ColorStyles, and by reverting _app.tsx to a previous state that uses the ThemeProvider from @primer/react-brand.

  • Removed custom dark mode context and provider
  • Removed dark mode toggle button and related styling
  • Cleaned up imports from components using dark mode specifics

Reviewed Changes

Copilot reviewed 8 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pages/_app.tsx Reverted to using ThemeProvider from @primer/react-brand and removed custom theme functionality
context/ThemeContext.tsx Entirely removed custom dark mode context
components/SDGFilter.tsx Removed use of ColorStyles
components/LanguageFilter.tsx Removed use of ColorStyles and consolidated Select props
components/Header/ThemeToggleButton.tsx Removed dark mode toggle button component
components/Header/Header.tsx Removed dark mode toggle component; manually set dark mode attribute
components/ColorStyles.tsx Removed custom ColorStyles file
Files not reviewed (3)
  • components/Header/Header.module.scss: Language not supported
  • package.json: Language not supported
  • styles/globals.scss: Language not supported

@seanmarcia seanmarcia merged commit dc0cd1e into main Apr 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant