Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhance Docker publish workflow with additional tagging options #160

Merged

Conversation

MayorFaj
Copy link
Contributor

@MayorFaj MayorFaj commented Apr 7, 2025

This pull request includes a significant update to the docker-publish.yml workflow file. The primary change is the addition of multiple tagging rules for Docker images, which enhances the flexibility and control over how images are tagged during the publishing process.

Enhancements to Docker image tagging:

  • .github/workflows/docker-publish.yml: Added various tagging rules including schedule-based, branch-based, tag-based, pull request-based, semantic versioning patterns, SHA, edge, match, and PEP 440. Additionally, a custom rule was added to prevent pre-releases from getting the "latest" tag.

Closes #156`

@Copilot Copilot bot review requested due to automatic review settings April 7, 2025 18:05
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

.github/workflows/docker-publish.yml:79

  • The 'type=match' rule does not include a pattern or additional configuration, which may lead to unintended matching behavior. Please review and add the necessary parameters if a specific pattern is intended.
            type=match

@MayorFaj MayorFaj requested a review from Copilot April 7, 2025 19:20
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

SamMorrowDrums
SamMorrowDrums previously approved these changes Apr 8, 2025
@SamMorrowDrums
Copy link
Collaborator

Thanks for this, I removed the match because it requires a pattern to be provided, but this is a big improvement on the existing tags.

@SamMorrowDrums SamMorrowDrums merged commit 3f62483 into github:main Apr 8, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't push release candidate docker images to :latest tag
2 participants