Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export issues funcs #163

Merged
merged 3 commits into from
Apr 8, 2025
Merged

chore: export issues funcs #163

merged 3 commits into from
Apr 8, 2025

Conversation

SamMorrowDrums
Copy link
Collaborator

Export issues functions outside the package.

@Copilot Copilot bot review requested due to automatic review settings April 7, 2025 21:23
@SamMorrowDrums SamMorrowDrums changed the base branch from main to export-code-scanning April 7, 2025 21:23
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR exports a set of GitHub issue and code scanning tool functions for external use.

  • Renames functions from unexported (lowercase) to exported (uppercase) in files: server.go, issues.go, and code_scanning.go.
  • Updates tests in issues_test.go and code_scanning_test.go to reference the new exported function names.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/github/server.go Updated tool functions to exported versions for issues handling.
pkg/github/issues_test.go Updated tests to use new exported function names; note potential syntax error.
pkg/github/issues.go Renamed internal functions to exported functions for issue handling.
pkg/github/code_scanning_test.go Updated tests to use exported function names for code scanning.
pkg/github/code_scanning.go Converted functions to exported, making code scanning tools accessible externally.

@SamMorrowDrums SamMorrowDrums changed the title Export issues chore: export issues funcs Apr 7, 2025
juruen
juruen previously approved these changes Apr 8, 2025
Copy link
Collaborator

@juruen juruen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Base automatically changed from export-code-scanning to main April 8, 2025 07:26
@SamMorrowDrums SamMorrowDrums dismissed juruen’s stale review April 8, 2025 07:26

The base branch was changed.

@SamMorrowDrums SamMorrowDrums merged commit f4770fa into main Apr 8, 2025
16 checks passed
@SamMorrowDrums SamMorrowDrums deleted the export-issues branch April 8, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants