Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export repository funcs #166

Merged
merged 1 commit into from
Apr 8, 2025
Merged

chore: export repository funcs #166

merged 1 commit into from
Apr 8, 2025

Conversation

SamMorrowDrums
Copy link
Collaborator

Export repository funcs to the public interface.

@Copilot Copilot bot review requested due to automatic review settings April 7, 2025 22:29
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the naming of various repository functions and tool definitions to export them on the public interface.

  • Renamed resource functions from lower-case to exported (capitalized) versions in pkg/github/server.go, pkg/github/repository_resource.go, and corresponding test files.
  • Updated tool functions in pkg/github/repositories.go and pkg/github/repositories_test.go to use capitalized, exported names.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/github/server.go Updated calls to resource functions to their exported versions.
pkg/github/repository_resource_test.go Updated tests to use exported resource handler functions.
pkg/github/repository_resource.go Renamed resource functions and handler to exported names.
pkg/github/repositories_test.go Updated tests to use exported tool function names.
pkg/github/repositories.go Renamed tool functions to exported names.
Comments suppressed due to low confidence (1)

pkg/github/server.go:59

  • [nitpick] The function 'searchRepositories' remains unexported while other repository functions have been updated to exported versions. Consider renaming it to 'SearchRepositories' for naming consistency if it is meant to be part of the public interface.
s.AddTool(searchRepositories(client, t))

juruen
juruen previously approved these changes Apr 8, 2025
Copy link
Collaborator

@juruen juruen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Base automatically changed from export-prs to main April 8, 2025 07:33
@SamMorrowDrums SamMorrowDrums dismissed juruen’s stale review April 8, 2025 07:33

The base branch was changed.

@SamMorrowDrums SamMorrowDrums merged commit c1bdd6a into main Apr 8, 2025
13 of 15 checks passed
@SamMorrowDrums SamMorrowDrums deleted the export-repositories branch April 8, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants