Update build from source instructions #224
Closed
+24
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefMa
requested review from
juruen,
SamMorrowDrums,
williammartin and
toby
as code owners
| + "stdio" | ||
| ], | ||
| "env": { | ||
| "GITHUB_PERSONAL_ACCESS_TOKEN": "${input:github_token} OR <YOUR_TOKEN>" |
There was a problem hiding this comment.
Users shouldn't be hardcoding PATs in a config file.
There was a problem hiding this comment.
I just copied it from the Claude Desktop section. What should it be instead? 🤔 And should I also update it in the Claude Desktop section?
There was a problem hiding this comment.
Oh fair enough, vscode supports password inputs which prompts for input when the server is launched. Claude doesn't appear to have that feature.
This was referenced Apr 11, 2025
|
We ended up going with #264 to clarify source install. Thank you for this though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just updated the description of the
build from sourcesection to make them more clear/obvious.I just thought it make sense because something like this was already requested
#215 which is IMHO more complicate to do than just use plain old
go.There is also this issues (#199) which ask for "Dockerless" solutions.
To me it seems that people needs some more help or guidance.
Let me know what do you think and if I should change something.
P.s.:
I haven't tested it
Just added what I think should work 🙃