Skip to content

[Schema Inaccuracy] Pull request references "team-simple", which is missing a "parent" property #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cbrunsdon opened this issue May 5, 2021 · 0 comments

Comments

@cbrunsdon
Copy link

Schema Inaccuracy

A #/components/schema/pull-request references #/components/schema/team-simple in its requested_teams field.

"requested_teams": {
  "type": "array",
  "items": {
    "$ref": "#/components/schemas/team-simple"
  },
  "nullable": true
}

Team-simple lacks a "parent" definition, which can be clearly seen in an api response for PRs.

Parent exists on team, but not team-simple.

Expected

Parent added to the description for team-simple, as seen in team:

"parent": {
  "nullable": true,
  "allOf": [
    {
      "$ref": "#/components/schemas/team-simple"
    }
  ]
}

Reproduction Steps

curl https://api.github.com/repos/solidusio/solidus/pulls/3794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants