Skip to content

[Schema Inaccuracy] githubCloudOnly flag set incorrectly? #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gr2m opened this issue Sep 15, 2021 · 0 comments
Open

[Schema Inaccuracy] githubCloudOnly flag set incorrectly? #553

gr2m opened this issue Sep 15, 2021 · 0 comments
Labels

Comments

@gr2m
Copy link
Contributor

gr2m commented Sep 15, 2021

The following routes set x-github.githubCloudOnly to false, but I think it should be true?

PUT /orgs/{org}/actions/runner-groups/{runner_group_id}/runners/{runner_id}
POST /orgs/{org}/actions/runner-groups
DELETE /orgs/{org}/actions/runner-groups/{runner_group_id}
GET /orgs/{org}/actions/runner-groups/{runner_group_id}
GET /orgs/{org}/actions/runner-groups/{runner_group_id}/repositories
GET /orgs/{org}/actions/runner-groups
GET /orgs/{org}/actions/runner-groups/{runner_group_id}/runners
DELETE /orgs/{org}/actions/runner-groups/{runner_group_id}/repositories/{repository_id}
DELETE /orgs/{org}/actions/runner-groups/{runner_group_id}/runners/{runner_id}
PUT /orgs/{org}/actions/runner-groups/{runner_group_id}/repositories
PUT /orgs/{org}/actions/runner-groups/{runner_group_id}/runners
PATCH /orgs/{org}/actions/runner-groups/{runner_group_id}
PUT /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}/organizations/{org_id}
PUT /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}/runners/{runner_id}
POST /enterprises/{enterprise}/actions/runners/registration-token
POST /enterprises/{enterprise}/actions/runners/remove-token
POST /enterprises/{enterprise}/actions/runner-groups
DELETE /enterprises/{enterprise}/actions/runners/{runner_id}
DELETE /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}
GET /enterprises/{enterprise}/actions/runners/{runner_id}
GET /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}
GET /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}/organizations
GET /enterprises/{enterprise}/actions/runners/downloads
GET /enterprises/{enterprise}/actions/runner-groups
GET /enterprises/{enterprise}/actions/runners
GET /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}/runners
DELETE /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}/organizations/{org_id}
DELETE /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}/runners/{runner_id}
PUT /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}/organizations
PUT /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}/runners
PATCH /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}

Ages ago I added a workaround for Octokit to set the flag correctly:
https://github.com/gr2m/github-openapi-graphql-query/blob/405891d8cd001f2c126174e6f1bf5f9847213a54/lib/workarounds.js

Unfortunately I didn't write down why the flag was set to false, I think there was a more complicated reason? I also think you had a plan to publish a dedicated OpenAPI spec for GitHub Enterprise Cloud, is that still the plan?

/cc @Eddman octokit/plugin-rest-endpoint-methods.js#448

@xuorig xuorig added the P3 label Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants