Fix: prevent arrow key nav conflict inside textareas #1445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for cyf-curriculum pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-piscine pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-launch pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-common pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-itd pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-sdc pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-tracks pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for cyf-programming ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
illicitonion
requested changes
May 12, 2025
There was a problem hiding this comment.
Thanks for picking this up! I tried this in the deploy preview (https://deploy-preview-1445--cyf-programming.netlify.app/data-groups/sprints/3/prep/#implementing-a-character-limit) and the left/right arrows still seem to have the buggy behaviour. Please could you take a look? I'd recommend running the site locally, and debugging interactively :)
github-project-automation
bot
moved this from 📋 Backlog
to 🔖 Ready
in Curriculum Planning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR fixes a bug where pressing the left or right arrow keys inside a textarea would trigger navigation to a different prep section instead of moving the cursor within the textarea.
The fix ensures that arrow key navigation handlers ignore key events when the focused element is an input or textarea.
Common Content?
Common Theme?
Issue number: #1072
Org Content?
A function fixed
Module | Sprint | Page Type | Block Type
Checklist
Who needs to know about this?