Only get freezedata on existing contests #2981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a annoying case, we only check if the contests exists after we know if the user has access. This prevents us from disclosing data but does require this null check.
Kevinjil
approved these changes
Apr 5, 2025
nickygerritsen
approved these changes
Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a annoying case, we only check if the contests exists after we know if the user has access. This prevents us from disclosing data but does require this null check.
I did not check if it fixes the issue, but given the small change I expect we get away with this on visual inspection.
Should fix https://domjudge.sentry.io/issues/6155964196/?alert_rule_id=11022917&alert_type=issue¬ification_uuid=d08175bd-ce4e-4e66-b1e3-49c72dfcef9e&project=6376669&referrer=slack